[TechDebt] Fix test coverage Tasking::construct_order_parameters #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javidq
requested changes
Oct 16, 2024
tests/test_tasking.py
Outdated
| acquisition_end="2022-11-10", | ||
| geometry=mock_search_parameters["intersects"], | ||
| class TestTasking: | ||
| @pytest.fixture(autouse=True) |
| @@ -14,6 +14,16 @@ | |||
|
|
|||
| logger = utils.get_logger(__name__) | |||
|
|
|||
| Geometry = Union[ | |||
There was a problem hiding this comment.
why don't we use catalog.Geometry?
There was a problem hiding this comment.
they are not the same. We can unify both, but I haven't tested if this has an impact.
# catalog.py
Geometry = Union[
dict,
geojson.Feature,
geojson.FeatureCollection,
list,
geopandas.GeoDataFrame,
geom.Polygon,
]
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "up42-py" | |||
| version = "2.1.0" | |||
| version = "2.2.0a1" | |||
up42/tasking.py
Outdated
| logger.info("See `tasking.get_data_product_schema(data_product_id)` for more detail on the parameter options.") | ||
| missing_params = {param: order_parameters["params"].get(param) for param in schema["required"]} | ||
| order_parameters["params"].update(missing_params) | ||
|
|
||
| geometry = utils.any_vector_to_fc(vector=geometry) | ||
| assert isinstance(order_parameters["params"], dict) |
up42/tasking.py
Outdated
| } | ||
| schema = self.get_data_product_schema(data_product_id) | ||
| params: dict[str, Any] = {param: None for param in schema["required"]} | ||
| params["displayName"] = name |
There was a problem hiding this comment.
params |= {
"displayName": name,
"acquisitionStart": utils.format_time(acquisition_start),
"acquisitionEnd": utils.format_time(acquisition_end, set_end_of_day=True),
}| params["displayName"] = name | ||
| params["acquisitionStart"] = utils.format_time(acquisition_start) | ||
| params["acquisitionEnd"] = utils.format_time(acquisition_end, set_end_of_day=True) | ||
| order_parameters: order.OrderParams = {"dataProduct": data_product_id, "params": params} |
There was a problem hiding this comment.
do we need typing hint here?
There was a problem hiding this comment.
If we don't add type, wouldn't be a dict type? pre-commit complains about it
tests/test_tasking.py
Outdated
| assert isinstance(order_parameters, dict) | ||
| assert list(order_parameters.keys()) == ["dataProduct", "params"] | ||
| assert order_parameters["params"]["acquisitionMode"] is None | ||
| def test_construct_order_parameters( |
There was a problem hiding this comment.
test_should_construct_order_parameters
tests/test_tasking.py
Outdated
| ) | ||
| order_parameters = tasking_obj.construct_order_parameters( | ||
| data_product_id=constants.DATA_PRODUCT_ID, | ||
| name="some-name", |
There was a problem hiding this comment.
let's extract this to a variable or constant since it's longer than 5 symbols
tests/test_tasking.py
Outdated
| self, | ||
| requests_mock: req_mock.Mocker, | ||
| tasking_obj: tasking.Tasking, | ||
| input_geometry: Optional[tasking.Geometry], |
tests/test_tasking.py
Outdated
Comment on lines
104
to
105
| "acquisitionStart": "2014-01-01T00:00:00Z", | ||
| "acquisitionEnd": "2022-12-31T23:59:59Z", |
There was a problem hiding this comment.
These two values should not be hard coded in the test, to be extracted to constants
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog.
Checklist: