Pass formState directly into createHtmlStream
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the hacky implementation of assigning the form state after server-side rendering has already begun. I believe in the React flight fixture this was only done because RSC rendering and SSR happens in two separate servers. So the form state needed to be extracted from the RSC response stream. Here, we can just pass it around. It seems Next.js is doing that as well (in a more convoluted way, so it's a bit complicated to follow the flow there): https://github.com/vercel/next.js/blob/canary/packages/next/src/server/app-render/app-render.tsx BREAKING CHANGE: The `fomState` now needs to be passed in as part of the options of `createHtmlStream`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the hacky implementation of assigning the form state after server-side rendering has already begun. I believe in the React flight fixture this was only done because RSC rendering and SSR happens in two separate servers. So the form state needed to be extracted from the RSC response stream. Here, we can just pass it around. It seems Next.js is doing that as well (in a more convoluted way, so it's a bit complicated to follow the flow there): https://github.com/vercel/next.js/blob/canary/packages/next/src/server/app-render/app-render.tsx
BREAKING CHANGE: The
formStatenow needs to be passed in as part of the options ofcreateHtmlStream.