-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more Package
properties
#9532
base: master
Are you sure you want to change the base?
Conversation
|
||
private DateTimeOffset GetInstallDate() => DateTimeOffset.Now; | ||
private DateTimeOffset GetInstallDate() => new DateTimeOffset(2000, 1, 1, 0, 0, 0, TimeSpan.Zero); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could create a file (or read some other file) on first launch then read the date so we can provide that date more reliably?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good idea! It would be the first launch date, but that is still more accurate than nothing 😀 . However, first we need to resolve #8910 so that it is really app specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use such placeholders? It is simply not supported atrribute.
App programmer should be warned on compile time that he/she should check app logic that uses GetInstalledDate.
E.g.: tryware, and logic as
if(date.Now - GetInstalledDate > 14 days) showerror("free use period ends, please buy this app")
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
The build 52398 found UI Test snapshots differences: Details
|
I think this is bad. Any API with behaviour that is not analog of UWP should be left as 'unimplemented', to signal to programmer that he/she should change app logic here - signal in intelliSense/build time. If you deceive programmer that such API works, only thorough testing of apps would reveal such errors (in a form of app crash in bizarre places and with bizarre messages). |
c7ea319
to
e1b89c5
Compare
The build 57351 found UI Test snapshots differences: Details
|
e1b89c5
to
b7f1f4b
Compare
The build 57537 found UI Test snapshots differences: Details
|
0011609
to
65d97fa
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-9532/index.html |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):