Add support for more Package properties
#9532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
reviewed
Aug 18, 2022
|
|
||
| private DateTimeOffset GetInstallDate() => DateTimeOffset.Now; | ||
| private DateTimeOffset GetInstallDate() => new DateTimeOffset(2000, 1, 1, 0, 0, 0, TimeSpan.Zero); |
There was a problem hiding this comment.
I wonder if we could create a file (or read some other file) on first launch then read the date so we can provide that date more reliably?
There was a problem hiding this comment.
That is a good idea! It would be the first launch date, but that is still more accurate than nothing 😀 . However, first we need to resolve #8910 so that it is really app specific.
There was a problem hiding this comment.
Why use such placeholders? It is simply not supported atrribute.
App programmer should be warned on compile time that he/she should check app logic that uses GetInstalledDate.
E.g.: tryware, and logic as
if(date.Now - GetInstalledDate > 14 days) showerror("free use period ends, please buy this app")
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The build 52398 found UI Test snapshots differences: Details
|
|
I think this is bad. Any API with behaviour that is not analog of UWP should be left as 'unimplemented', to signal to programmer that he/she should change app logic here - signal in intelliSense/build time. If you deceive programmer that such API works, only thorough testing of apps would reveal such errors (in a form of app crash in bizarre places and with bizarre messages). |
MartinZikmund
force-pushed
the
dev/mazi/install-path
branch
from
c7ea319
to
e1b89c5
Compare
|
The build 57351 found UI Test snapshots differences: Details
|
MartinZikmund
force-pushed
the
dev/mazi/install-path
branch
from
e1b89c5
to
b7f1f4b
Compare
|
The build 57537 found UI Test snapshots differences: Details
|
MartinZikmund
force-pushed
the
dev/mazi/install-path
branch
from
0011609
to
65d97fa
Compare
github-actions
bot
added
platform/android 🤖
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-9532/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):