Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ProgressRing/Bar): add Fluent tab to sample page #933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Arieldelossantos
Copy link

GitHub Issue (If applicable): #919

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-933.eastus2.3.azurestaticapps.net

Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test out on windows & skia?
and please remove line 20 too, once confirmed working?

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/fluent-tab-progress-ring branch from 6feb18e to d93c42b Compare October 19, 2023 11:52
@Arieldelossantos
Copy link
Author

Arieldelossantos commented Oct 19, 2023

did you test out on windows & skia? and please remove line 20 too, once confirmed working?

confirmed it works in both platforms @Xiaoy312

PR updated and ready @agneszitte

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-933.eastus2.3.azurestaticapps.net

@kazo0
Copy link
Contributor

kazo0 commented Oct 19, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Arieldelossantos Arieldelossantos force-pushed the dev/arde/fluent-tab-progress-ring branch from d93c42b to ebe626c Compare November 2, 2023 13:08
Copy link

github-actions bot commented Nov 2, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-933.eastus2.3.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants