Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinguish enums by declarationType #329

Merged
merged 9 commits into from
May 25, 2024
Merged

Conversation

tmg0
Copy link
Contributor

@tmg0 tmg0 commented Feb 22, 2024

πŸ”— Linked issue

Resolves #318

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Upgrade mlly version to 1.6.0. Use the declarationType in ESMExport.

Renew the pr: fix: re export ts enum type
Fix typescript enum auto import error, enum should be imported as both value and type.

Resolves #318

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 98.73%. Comparing base (d6b3b38) to head (4ae8cc9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   98.73%   98.73%   -0.01%     
==========================================
  Files          14       14              
  Lines        1822     1817       -5     
  Branches      371      374       +3     
==========================================
- Hits         1799     1794       -5     
  Misses         23       23              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

src/types.ts Outdated Show resolved Hide resolved
@danielroe danielroe requested a review from antfu May 24, 2024 12:57
@antfu antfu merged commit a4a5e0a into unjs:main May 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-import for enum is not working: TS2749: 'User' refers to a value, but is being used as a type
3 participants