Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added WritableComputedRef to preset types for vuejs auto import #266

Merged
merged 2 commits into from
Aug 23, 2023
Merged

feat: added WritableComputedRef to preset types for vuejs auto import #266

merged 2 commits into from
Aug 23, 2023

Conversation

rivermanbw
Copy link
Contributor

@rivermanbw rivermanbw commented Aug 23, 2023

πŸ”— Linked issue

close #265

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Though computed can return ComputedRef and WritableComputedRef, I'd expect those two to be apreset return type as well. Therefore I added WritableComputedRef to preset types

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

WritableComputedRef maybe as heavily used as ComputedRef. Therefore added it preset vue type
@antfu antfu merged commit 03751ba into unjs:main Aug 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WritableComputedRef as preset type for vuejs
2 participants