fix: support deep ternary injection (#293)

unjs · Nov 9, 2023 · 189da45 · 189da45
1 parent 46f84f7
commit 189da45
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/context.ts b/src/context.ts
@@ -237,7 +237,9 @@ async function detectImports (code: string | MagicString, ctx: UnimportContext,
         }
         // Remove property, but keep `case x:` and `? x :`
         const end = strippedCode[i.index! + i[0].length]
-        if (end === ':' && !['?', 'case'].includes(i[1].trim())) {
+        // also keeps deep ternary like `true ? false ? a : b : c`
+        const before = strippedCode[i.index! - 1]
+        if (end === ':' && !['?', 'case'].includes(i[1].trim()) && before !== ':') {
           return null
         }
         const name = i[2]

diff --git a/test/inject.test.ts b/test/inject.test.ts
@@ -151,4 +151,19 @@ import { baz } from 'baz'
         import { baz } from 'baz'"
       `)
   })
+
+  test('deep ternary inject', async () => {
+    const { injectImports } = createUnimport({
+      imports: [
+        { name: 'A', from: 'test-id' },
+        { name: 'B', from: 'test-id' },
+        { name: 'C', from: 'test-id' }
+      ]
+    })
+    expect((await injectImports('const result = true ? false ? A : B : C')).code)
+      .toMatchInlineSnapshot(`
+        "import { A, B, C } from 'test-id';
+        const result = true ? false ? A : B : C"
+      `)
+  })
 })