-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LRE build error #2541
LRE build error #2541
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 90 92 +2
Lines 4158 4161 +3
=======================================
+ Hits 4105 4108 +3
Misses 53 53 ☔ View full report in Codecov by Sentry. |
58d249c
to
77b7727
Compare
|
SO that might be possibly related to this issue. It's not clear why the build passes locally but fails with a Another related discussion in RTD repo on why a submodule couldn't be imported. Why only LRE import issues though? Why not other submodules? Edit: I think this is happening because the submodules do not have init files. |
@natestemen I managed to get the import issues fixed by adding init files in the submodules. |
@natestemen this is ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's good practice for files to end with a new line (even those init files)
Having init files in the submodules is a good practice. |
Description
Test PR to check if the errors noticed by Nate persist for all builds. Tested the build locally without any issues.
License
Before opening the PR, please ensure you have completed the following where appropriate.