-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cirq-core requirement from <1.4.0,>=1.0.0 to >=1.0.0,<1.5.0 #2390
Update cirq-core requirement from <1.4.0,>=1.0.0 to >=1.0.0,<1.5.0 #2390
Conversation
Updates the requirements on [cirq-core](https://github.com/quantumlib/cirq) to permit the latest version. - [Release notes](https://github.com/quantumlib/cirq/releases) - [Changelog](https://github.com/quantumlib/Cirq/blob/main/release.md) - [Commits](quantumlib/Cirq@v1.0.0...v1.4.0) --- updated-dependencies: - dependency-name: cirq-core dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2390 +/- ##
==========================================
- Coverage 98.71% 98.71% -0.01%
==========================================
Files 89 89
Lines 4133 4131 -2
==========================================
- Hits 4080 4078 -2
Misses 53 53 ☔ View full report in Codecov by Sentry. |
In In fact, we should not have code that depends on functions (from external modules) that are intended for internal use (single underscore functions). |
Doing a quick search, I also found:
Both of these functions still exist. |
Thanks, @bdg221. Ideally we want to get rid of all of those cirq internal function calls in Mitiq. |
The solution I implemented in commmit ad9249d in this PR only works with This makes the tests break at the moment. However, if we want to support Python 3.12 and drop Python 3.9, we will want to enforce a dependency to |
A newer version of cirq-core exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
From mitiq coding session:
|
d5dbb96
to
81ed959
Compare
After further restricting the cirq version, the documentation was still failing with an error trying to load a pickled I chose JSON as the replacement as it is the first thing in the cirq docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for wrapping this up!
By ripple effect of this, we'll be able to upgrade PyQuil to v4 and other dependencies.
with open(f"{file_directory}/rshadows-tutorial-1D_Ising_g=1_{num_qubits}qubits.pkl", "rb") as file: | ||
old_cirq_circuit = pickle.load(file) | ||
circuit = cirq.Circuit(old_cirq_circuit.all_operations()) | ||
with open(f"{file_directory}/rshadows-tutorial-1D_Ising_g=1_{num_qubits}qubits.json", "rb") as file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoa, awesome that we finally got rid of those pickles 🥒
Updates the requirements on cirq-core to permit the latest version.
Release notes
Sourced from cirq-core's releases.
... (truncated)
Commits
ab96766
Fix expected package version in the tests8aa1725
Removing 1.4.0.dev -> 1.4.0ab86979
Flush deprecations before minor release (#6622)a9776d0
Nicer string representation for InverseCompositeGate (#6262)2cfdf1f
Add convenience methods to create PhasedXZ gate from ZYZ decomposition (#6569)1a8caa4
Proper text files end with a newline character (#6614)778e9e9
Freshen-up cirq dependencies (#6616)e4b6ab2
Fix spurious failure of the check/all script (#6611)ee4d702
enable simulation of controlled gates in classical simulator (#6589)528b2d2
Update list of pre-release notebooks (#6609)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)