Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unit tests for benchmarking circuits #2366

Merged
merged 3 commits into from
May 15, 2024

Conversation

purva-thakre
Copy link
Contributor

@purva-thakre purva-thakre commented May 15, 2024

Description

Adds tests for 3 items in #2365


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

@purva-thakre purva-thakre marked this pull request as ready for review May 15, 2024 02:53
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.32%. Comparing base (7a7bbfd) to head (28093c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2366      +/-   ##
==========================================
+ Coverage   98.22%   98.32%   +0.09%     
==========================================
  Files          87       87              
  Lines        4059     4059              
==========================================
+ Hits         3987     3991       +4     
+ Misses         72       68       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@purva-thakre purva-thakre force-pushed the missing_benchmarks_unit_tests branch from 9ada54b to 28093c4 Compare May 15, 2024 12:00
Copy link
Contributor

@cosenal cosenal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM.

@purva-thakre purva-thakre merged commit aefc5ce into main May 15, 2024
18 checks passed
@purva-thakre purva-thakre deleted the missing_benchmarks_unit_tests branch May 15, 2024 14:28
@purva-thakre purva-thakre mentioned this pull request May 18, 2024
22 tasks
cosenal pushed a commit that referenced this pull request Jun 26, 2024
* mirror circuits

* randomized benchmarking

* clifford t + ruff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants