Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawal #7

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Withdrawal #7

merged 1 commit into from
Jan 3, 2024

Conversation

apbendi
Copy link
Collaborator

@apbendi apbendi commented Dec 13, 2023

This PR implements the withdraw method for retrieving one's staked tokens from a previous deposit. The PR implements the access rules and internal accounting associated with the withdrawal.

This PR does not yet include any of the reward mechanics associated with withdrawal.

Copy link
Collaborator

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe add an additional assert to some of the tests

test/UniStaker.t.sol Show resolved Hide resolved
test/UniStaker.t.sol Outdated Show resolved Hide resolved
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

github-actions bot commented Jan 3, 2024

Coverage after merging withdrawal into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol96.43%75%100%100%69

@apbendi apbendi merged commit 20f1922 into main Jan 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants