feature: support string column validation for pandas 2.1.3 #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlma821
changed the title
Signed-off-by: karlma821 <[email protected]>
Signed-off-by: karlma821 <[email protected]>
karlma821
force-pushed
the
feature/1424
branch
from
51a24fb to
d2ae52b
Compare
|
@cosmicBboy please help review the PR 🙏🏼 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1425 +/- ##
==========================================
+ Coverage 94.23% 94.25% +0.01%
==========================================
Files 91 91
Lines 6976 6976
==========================================
+ Hits 6574 6575 +1
+ Misses 402 401 -1 ☔ View full report in Codecov by Sentry. |
cosmicBboy
approved these changes
Dec 4, 2023
|
Thanks @karlma821 and congrats on your first PR to pandera! 🚀 |
max-raphael
pushed a commit
to max-raphael/pandera
that referenced
this pull request
Jan 24, 2025
…ss#1425) * fix: always cast series to bool dtype Signed-off-by: karlma821 <[email protected]> * test: add test_pandas_data_type_check Signed-off-by: karlma821 <[email protected]> --------- Signed-off-by: karlma821 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem and solution are as described in #1424.
This PR
is_python_string.astype(bool)inNpString.checkdata_type.checkto ensure the check results are always boolean or reduceable to boolean-like by.all(), in order to pass the column validation inArraySchemaBackend.check_dtype