Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add buildkit install guide #377

Merged
merged 1 commit into from
Mar 2, 2024
Merged

docs: Add buildkit install guide #377

merged 1 commit into from
Mar 2, 2024

Conversation

felipehuici
Copy link
Member

No description provided.

razvand
razvand requested changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @felipehuici , looks good. See my comments.

content/guides/building-dockerfile-images-with-buildkit.mdx Outdated Show resolved Hide resolved
content/guides/building-dockerfile-images-with-buildkit.mdx Outdated Show resolved Hide resolved
content/guides/building-dockerfile-images-with-buildkit.mdx Outdated Show resolved Hide resolved
content/guides/building-dockerfile-images-with-buildkit.mdx Outdated Show resolved Hide resolved
razvand
razvand requested changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments and we should be OK.

Do a squash of all commits to only have one commit.

content/guides/building-dockerfile-images-with-buildkit.mdx Show resolved Hide resolved
content/guides/building-dockerfile-images-with-buildkit.mdx Outdated Show resolved Hide resolved
content/guides/building-dockerfile-images-with-buildkit.mdx Outdated Show resolved Hide resolved
@felipehuici felipehuici force-pushed the fhuici/add-buildkit-guide branch from 33ca502 to e4224bc Compare March 2, 2024 10:05
@razvand razvand force-pushed the fhuici/add-buildkit-guide branch from e4224bc to 8b5fc38 Compare March 2, 2024 10:45
@razvand razvand self-requested a review March 2, 2024 10:45
@razvand razvand self-assigned this Mar 2, 2024
razvand
razvand approved these changes Mar 2, 2024
View reviewed changes
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @felipehuici

Reviewed-by: Razvan Deaconescu [email protected]
Approved-by: Razvan Deaconescu [email protected]

@razvand razvand merged commit 620a7ac into main Mar 2, 2024
2 of 4 checks passed
@razvand razvand deleted the fhuici/add-buildkit-guide branch March 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvand razvand razvand approved these changes

Assignees

@razvand razvand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipehuici @razvand