fix(workflows): Various fixes and changes #130
+173
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All catalog entries must follow the following format: library/<APP_NAME>:<APP_VERSION> Signed-off-by: Alexander Jung <[email protected]>
Signed-off-by: Alexander Jung <[email protected]>
Signed-off-by: Alexander Jung <[email protected]>
Signed-off-by: Alexander Jung <[email protected]>
Signed-off-by: Alexander Jung <[email protected]>
This is because the accompanying action, `actions/upload-artifact` is still at v3 which is stated as non-compatible. Additionally, the README for v4 indicates major changes and backward compatibility issues. The easy fix for now to solve merging OCI manifests together (which fails currently because it cannot retrieve the downloaded artifacts from the previous dependent workflows), is just to simply downgrade. A solution in the future which upgrades must also adjust the action settings in order to achieve the same functionality. Signed-off-by: Alexander Jung <[email protected]>
These pipelines consistently fail across PRs and are always ignored. Additional work is necessary, either through configuration or by maintenance to the repository, for this workflow to pass. For now, simply remove until a solution can be determined. Signed-off-by: Alexander Jung <[email protected]>
Signed-off-by: Alexander Jung <[email protected]>
craciunoiuc
reviewed
Jan 14, 2025
| @@ -16,7 +16,7 @@ runs: | |||
| using: composite | |||
| steps: | |||
| - name: Retrieve OCI digests | |||
| uses: actions/download-artifact@v4 | |||
| uses: actions/download-artifact@v3 | |||
There was a problem hiding this comment.
still we should use v4 everywhere and adapt if necessary
There was a problem hiding this comment.
only this comment from my side, we can merge after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several fixes to the existing set of workflows in order to prevent breaks; improve consistency; as well as improve efficiency and legibility.