Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: Allow all tags #7

Merged
merged 1 commit into from
Nov 14, 2023
Merged

css: Allow all tags #7

merged 1 commit into from
Nov 14, 2023

Conversation

ananos
Copy link
Contributor

@ananos ananos commented Nov 12, 2023

This is a workaround until we understand how to fix this. AFAIK, the purgecss component excludes tags from the generated css so the resulting website was missing some tags. It is now clear why this happens only when executed on GH actions and not locally.

@ananos ananos requested review from razvand and nderjung November 12, 2023 22:06
@ananos ananos force-pushed the feat_fix_broken_css branch 2 times, most recently from 1eee8e9 to 21b543a Compare November 12, 2023 22:19
@razvand razvand self-assigned this Nov 13, 2023
Copy link
Member

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ananos ananos force-pushed the feat_fix_broken_css branch 2 times, most recently from 8ae821f to ae22dc9 Compare November 13, 2023 06:20
@ananos
Copy link
Contributor Author

ananos commented Nov 13, 2023

should be good to go

This is a workaround until we understand how to fix this.
AFAIK, the purgecss component excludes tags from the generated
css so the resulting website was missing some tags. It is not
clear why this happens only when executed on GH actions and not
locally.

Signed-off-by: Anastassios Nanos <[email protected]>
@ananos ananos force-pushed the feat_fix_broken_css branch from ae22dc9 to 1a681b5 Compare November 13, 2023 06:24
@ananos
Copy link
Contributor Author

ananos commented Nov 13, 2023

should be good to go

fixed a misleading typo in the commit message:
now->not

@razvand razvand self-requested a review November 14, 2023 10:07
Copy link
Member

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ananos

@ananos ananos merged commit 2caf996 into main Nov 14, 2023
2 checks passed
@ananos ananos deleted the feat_fix_broken_css branch November 14, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants