Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix according to linter reports #6

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix according to linter reports #6

merged 2 commits into from
Nov 14, 2023

Conversation

razvand
Copy link
Member

@razvand razvand commented Nov 12, 2023

Fix current content according to linting issues reported by GitHub action (super-linter, spellcheck).

@razvand razvand added the enhancement New feature or request label Nov 12, 2023
@razvand razvand requested review from foxeng and StefanJum November 12, 2023 16:10
@razvand razvand force-pushed the razvand/fix-linter-reports branch from b4f48ed to 82cc0c2 Compare November 12, 2023 16:36
StefanJum
StefanJum reviewed Nov 12, 2023
View reviewed changes
Copy link
Contributor

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @razvand, but there is a conflict with the main branch.

@razvand
README.md: Capitalize words in titles
253697d 
Capitalize words in section titles. Remove ending colon (`:`).

Signed-off-by: Razvan Deaconescu <[email protected]>
@razvand
layouts/index: Use proper spacing
8e2769a 
Use multiply-of-two for spacing. This is to comply with the
`.editorconfig` checks.

Signed-off-by: Razvan Deaconescu <[email protected]>
@razvand razvand force-pushed the razvand/fix-linter-reports branch from 82cc0c2 to 8e2769a Compare November 14, 2023 10:11
@razvand razvand requested a review from StefanJum November 14, 2023 10:11
@razvand
Copy link
Member Author

razvand commented Nov 14, 2023

Looks good @razvand, but there is a conflict with the main branch.

@StefanJum , fixed.

StefanJum
StefanJum suggested changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@razvand add the urls on lines 29 and 205 in backticks (I can't add code suggestions since there are no changes to those lines). That should solve the last linter errors and it should be good to go.

@razvand
Copy link
Member Author

razvand commented Nov 14, 2023

@razvand add the urls on lines 29 and 205 in backticks (I can't add code suggestions since there are no changes to those lines). That should solve the last linter errors and it should be good to go.

I think that would be stupid. Links should be clickable and not between backticks. The spellchecker itself should ignore them. I created the commit here, but it seems it doesn't work.

@razvand razvand requested a review from StefanJum November 14, 2023 13:07
@razvand
Copy link
Member Author

razvand commented Nov 14, 2023

@razvand add the urls on lines 29 and 205 in backticks (I can't add code suggestions since there are no changes to those lines). That should solve the last linter errors and it should be good to go.

I think that would be stupid. Links should be clickable and not between backticks. The spellchecker itself should ignore them. I created the commit here, but it seems it doesn't work.

Oh, I'm stupid. This is on the super-linter side. Let's disable that bare URL feature. It's stupid, IMO.

StefanJum
StefanJum approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@StefanJum StefanJum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's disable that bare URL feature. It's stupid, IMO.

Agreed, see open-education-hub/actions#28
All good besides.

@ananos
Copy link
Contributor

ananos commented Nov 14, 2023

ignoring linting issues & merging.

@ananos ananos merged commit 5bffc1a into unikernelalliance:main Nov 14, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanJum StefanJum StefanJum approved these changes

@foxeng foxeng Awaiting requested review from foxeng

Assignees

@ananos ananos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@razvand @ananos @StefanJum