CLDR-18256 Add TimePrecision option to semantic skeletons #4325
+69
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richgillam You had some opinions on the TimePrecision options. PTAL at what I ended up with. It doesn't represent all possible values of min/max time fields, but it covers the use cases we know about, and we can add more when needed. |
|
Also CC @echeran who has been working with the resolution algorithm. |
richgillam
previously approved these changes
Jan 30, 2025
|
@AEApple said on Jira: "Would you mind updating the PR to update the modifications section as well as part of this PR" Could someone point me to where to update the modifications section? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18256
As discussed in the CLDR Design WG.
The spec I ended up implementing here is almost the same as proposed in the doc, but I touched up some other things while I was in here.
ALLOW_MANY_COMMITS=true