-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17014 Change HashMap to ConcurrentHashMap in ExtraPaths #4321
Conversation
-ConcurrentModificationException was thrown when ExtraPaths.getInstance called computeIfAbsent during cldr-generate-json.sh -Unable to repro the exception before making this change; anyway, this should prevent it
Compare older alternative #4317 which adds |
This fails ConsoleCheckCLDR:
|
@macchiati @srl295 tests passed locally but ConsoleCheckCLDR fails here, so maybe we need |
I don't often run ConsoleCheckCLDR locally, and didn't run it before making this PR. Running it locally now, I do get ConcurrentModificationException:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see ticket
-ConcurrentModificationException was thrown when ExtraPaths.getInstance called computeIfAbsent during cldr-generate-json.sh
-Unable to repro the exception before making this change
CLDR-17014
ALLOW_MANY_COMMITS=true