CLDR-18253 Add en_JP, en_KR, en_TW #4305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srl295 @btangmu @macchiati - Is there an easier way to identify where I'm missing sideways inheritance that I need to add back? I had only kept the items where something was different, but I must have removed something that I should have made inherit instead, I'm just not sure how to find it well without re-adding back things in the sections with only a couple of items. |
|
Sorry, was occupied. Will check tomorrow
…On Wed, Jan 22, 2025, 14:49 Annemarie Apple ***@***.***> wrote:
@srl295 <https://github.com/srl295> @btangmu <https://github.com/btangmu>
@macchiati <https://github.com/macchiati> - Is there an easier way to
identify where I'm missing sideways inheritance that I need to add back? I
had only kept the items where something was different, but I must have
removed something that I should have made inherit instead, I'm just not
sure how to find it well without re-adding back things in the sections with
only a couple of items.
—
Reply to this email directly, view it on GitHub
<#4305 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMGOKTIOIZFZON2VVBD2MAOBDAVCNFSM6AAAAABVVKLZVSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBYGQZDMNZVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
| <short> | ||
| <standard>SGT</standard> | ||
| </short> | ||
| </metazone> |
There was a problem hiding this comment.
This is definitely missing Japan's own time zone, JST.
There was a problem hiding this comment.
That sounds reasonable; perhaps similar actions for other locales.
Annemarie, I'm happy to approve now, if we want to get it in to the first ICU integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18253
Will add other locales as soon as en_JP passes the test.
ALLOW_MANY_COMMITS=true