refactor: a huge update #25
Conversation
WalkthroughThe updates in this set aim to enhance tooling and dependency management across the project. Changes include upgrading GitHub actions, adjusting ignored files, updating dependencies, improving ESLint and Prettier settings, introducing new configuration files, and adding configurations and types across various packages. These updates collectively streamline development processes and ensure compatibility with the latest tools and libraries. Changes
Possibly related issues
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (1)
Files selected for processing (7)
Files not summarized due to errors (1)
Files skipped from review as they are similar to previous changes (6)
Additional comments not posted (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 16
Out of diff range and nitpick comments (10)
packages/core/src/config/types/mpKuaishou.ts (1)
3-29: Ensure consistent documentation and interface structure.
- Consider adding a description for the
MpKuaishouinterface itself to provide context.- The property
appidcould use a more detailed comment, especially about its optional nature and where one might find this appid.- For the
optimizationobject, consider specifying what types of optimizations are possible or expected.- The
scopedSlotsCompilerproperty's comment is clear, but ensure that the versions mentioned are accurate and supported..github/workflows/release.yml (1)
Line range hint
12-38: Review and optimize the GitHub Actions workflow.
- The
fetch-depth: 0in the checkout step retrieves the entire commit history, which might not be necessary and could slow down the workflow. Consider using a limited fetch depth if the full history is not required.- The
pnpm -r publishcommand includes--no-git-checks. Ensure that this is intentional and understand the implications, as it bypasses checks that might prevent publishing errors.packages/core/src/config/types/mpBaidu.ts (1)
3-39: Ensure consistent documentation and interface structure forMpBaidu.
- Similar to
MpKuaishou, add a description for theMpBaiduinterface to provide context.- The
requiredBackgroundModesproperty is well-documented. Ensure that the array type is correctly used and that the possible values are validated.- Review the
scopedSlotsCompilerandslotMultipleInstanceproperties for accuracy in version support and functionality description.packages/core/src/config/types/mpLark.ts (1)
3-52: Ensure consistent documentation and interface structure forMpLark.
- Add a description for the
MpLarkinterface to provide context.- The
settingobject includes several properties likees6,minified, andpostcss. Ensure that these properties are clearly explained and that their default values are accurately represented.- Review the
scopedSlotsCompilerandslotMultipleInstanceproperties for accuracy in version support and functionality description.packages/core/src/config/types/mpToutiao.ts (1)
3-61: Ensure consistent documentation and interface structure forMpToutiao.
- Add a description for the
MpToutiaointerface to provide context.- The
settingobject includes several properties likees6,urlCheck, andpostcss. Ensure that these properties are clearly explained and that their default values are accurately represented.- Review the
scopedSlotsCompilerandslotMultipleInstanceproperties for accuracy in version support and functionality description.packages/core/src/config/types/appPlus.ts (5)
18-18: Consider providing more context or examples in the documentation forignoreVersion. It's unclear what "running environment" and "compiling environment" refer to.
23-23: TheruntimeVersionproperty should specify the format expected for version strings, especially since multiple versions can be specified.
38-38: ThecompilerVersionproperty should clarify what the numbers2and3signify. Are these version numbers, and if so, what do they correspond to?
1564-1564: Therunmodeproperty offers 'normal' and 'liberate' as options, which can significantly affect how resources are managed. Document the implications of each mode thoroughly to aid developers in making an informed choice.
1610-1610: Thex5.showTipsWithoutWifiproperty is set tofalseby default, which could affect user experience on mobile data. Consider the implications of this setting and possibly offer a configuration option to the user.
|
@coderabbitai review |
|
牛牛牛，明天看一看 |
|
如果没有进一步的评论，我可能会在两天内合并 🙏 |
Description 描述
这个 PR 相当大，做了以下的工作：
Linked Issues 关联的 Issues
uni-helper/uni-app-schemas-vscode#20
Additional context 额外上下文
我不认为存在对外的破坏性更新，但存在对内的破坏性更新，该 PR 仍然需要仔细审查。
Summary by CodeRabbit
New Features
manifest.jsonfor the "uni-helper" Uni-app.pages.jsonin uni-app.Enhancements
[email protected].Documentation
Bug Fixes
manifest.jsonfrom.gitignoreto ensure it is tracked and updated.Chores
pnpm-workspace.yamlto include all packages in thepackagesdirectory..nvmrc.