Skip to content

Commit

Permalink
Update to Chromium 127.0.6533.72
Browse files Browse the repository at this point in the history
  • Loading branch information
Ahrotahn committed Jul 23, 2024
1 parent 32e2931 commit 3745260
Show file tree
Hide file tree
Showing 64 changed files with 4,580 additions and 1,121 deletions.
2 changes: 1 addition & 1 deletion chromium_version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
126.0.6478.182
127.0.6533.72
376 changes: 255 additions & 121 deletions domain_substitution.list

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion patches/core/bromite/disable-fetching-field-trials.patch
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Subject: Disable fetching of all field trials
/**
--- a/components/variations/service/variations_service.cc
+++ b/components/variations/service/variations_service.cc
@@ -224,17 +224,7 @@ bool GetInstanceManipulations(const net:
@@ -226,17 +226,7 @@ bool GetInstanceManipulations(const net:
// Variations seed fetching is only enabled in official Chrome builds, if a URL
// is specified on the command line, and for testing.
bool IsFetchingEnabled() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -2434,7 +2434,6 @@ static_library("browser") {
@@ -2400,7 +2400,6 @@ static_library("browser") {
"//components/reporting/util:task_runner_context",
"//components/resources",
"//components/safe_browsing/content/browser",
- "//components/safe_browsing/content/browser:client_side_detection",
"//components/safe_browsing/content/browser:safe_browsing_service",
"//components/safe_browsing/content/browser/password_protection",
"//components/safe_browsing/content/browser/web_ui",
@@ -3882,8 +3881,6 @@ static_library("browser") {
@@ -3864,8 +3863,6 @@ static_library("browser") {
"download/download_commands.h",
"download/download_crx_util.cc",
"download/download_crx_util.h",
Expand Down Expand Up @@ -50,7 +50,7 @@
#include "chrome/browser/shell_integration.h"
#include "chrome/browser/site_isolation/prefs_observer.h"
#include "chrome/browser/ssl/secure_origin_prefs_observer.h"
@@ -458,8 +457,6 @@ void BrowserProcessImpl::StartTearDown()
@@ -456,8 +455,6 @@ void BrowserProcessImpl::StartTearDown()
#endif
metrics_services_manager_.reset();
intranet_redirect_detector_.reset();
Expand All @@ -59,7 +59,7 @@
network_time_tracker_.reset();

#if !BUILDFLAG(IS_ANDROID) && !BUILDFLAG(IS_CHROMEOS)
@@ -1138,14 +1135,6 @@ StatusTray* BrowserProcessImpl::status_t
@@ -1136,14 +1133,6 @@ StatusTray* BrowserProcessImpl::status_t
return status_tray_.get();
}

Expand All @@ -74,7 +74,7 @@
subresource_filter::RulesetService*
BrowserProcessImpl::subresource_filter_ruleset_service() {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
@@ -1453,26 +1442,6 @@ void BrowserProcessImpl::CreateBackgroun
@@ -1451,26 +1440,6 @@ void BrowserProcessImpl::CreateBackgroun
#endif
}

Expand Down Expand Up @@ -144,7 +144,7 @@
browsing_data::RemoveFederatedSiteSettingsData(delete_begin_, delete_end_,
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -5187,10 +5187,6 @@ ChromeContentBrowserClient::CreateThrott
@@ -5248,10 +5248,6 @@ ChromeContentBrowserClient::CreateThrott
throttles.push_back(std::make_unique<PolicyBlocklistNavigationThrottle>(
handle, handle->GetWebContents()->GetBrowserContext()));

Expand All @@ -155,7 +155,7 @@
throttles.push_back(std::make_unique<SSLErrorNavigationThrottle>(
handle,
base::BindOnce(&HandleSSLErrorWrapper), base::BindOnce(&IsInHostedApp),
@@ -5242,16 +5238,6 @@ ChromeContentBrowserClient::CreateThrott
@@ -5303,16 +5299,6 @@ ChromeContentBrowserClient::CreateThrott
&throttles);
#endif

Expand All @@ -172,7 +172,7 @@
if (base::FeatureList::IsEnabled(safe_browsing::kDelayedWarnings)) {
throttles.push_back(
std::make_unique<safe_browsing::DelayedWarningNavigationThrottle>(
@@ -5569,8 +5555,6 @@ bool ChromeContentBrowserClient::IsPlugi
@@ -5617,8 +5603,6 @@ bool ChromeContentBrowserClient::IsPlugi
void ChromeContentBrowserClient::InitOnUIThread() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);

Expand Down Expand Up @@ -207,7 +207,7 @@
} // namespace
--- a/chrome/browser/download/chrome_download_manager_delegate.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate.cc
@@ -504,13 +504,6 @@ void ChromeDownloadManagerDelegate::SetD
@@ -514,13 +514,6 @@ void ChromeDownloadManagerDelegate::SetD

download_manager_ = dm;

Expand All @@ -221,7 +221,7 @@
if (download_manager_) {
download_manager_->AddObserver(this);
}
@@ -940,17 +933,6 @@ void ChromeDownloadManagerDelegate::Choo
@@ -955,17 +948,6 @@ void ChromeDownloadManagerDelegate::Choo
void ChromeDownloadManagerDelegate::SanitizeSavePackageResourceName(
base::FilePath* filename,
const GURL& source_url) {
Expand Down Expand Up @@ -322,7 +322,7 @@
// If no mime type or explicitly specified a name, don't replace file
// extension.
if (sniffed_mime_type.empty() || !suggested_filename.empty())
@@ -1290,30 +1283,7 @@ DownloadFileType::DangerLevel DownloadTa
@@ -1291,30 +1284,7 @@ DownloadFileType::DangerLevel DownloadTa
download_->HasUserGesture())
return DownloadFileType::NOT_DANGEROUS;

Expand Down Expand Up @@ -500,7 +500,7 @@
referrer_entries)));
--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
@@ -697,18 +697,6 @@ void WebstorePrivateBeginInstallWithMani
@@ -701,18 +701,6 @@ void WebstorePrivateBeginInstallWithMani

void WebstorePrivateBeginInstallWithManifest3Function::
ReportFrictionAcceptedEvent() {
Expand All @@ -519,7 +519,7 @@
}

void WebstorePrivateBeginInstallWithManifest3Function::OnInstallPromptDone(
@@ -1207,54 +1195,9 @@ WebstorePrivateGetReferrerChainFunction:
@@ -1217,54 +1205,9 @@ WebstorePrivateGetReferrerChainFunction:

ExtensionFunction::ResponseAction
WebstorePrivateGetReferrerChainFunction::Run() {
Expand Down Expand Up @@ -655,7 +655,7 @@
#include "chrome/browser/sessions/exit_type_service.h"
#include "chrome/browser/sharing/sharing_service_factory.h"
#include "chrome/browser/signin/identity_manager_factory.h"
@@ -639,17 +638,6 @@ void ProfileImpl::LoadPrefsForNormalStar
@@ -643,17 +642,6 @@ void ProfileImpl::LoadPrefsForNormalStar

mojo::PendingRemote<prefs::mojom::TrackedPreferenceValidationDelegate>
pref_validation_delegate;
Expand All @@ -675,7 +675,7 @@
CreatePrefService(pref_registry_, CreateExtensionPrefStore(this, false),
--- a/chrome/browser/profiles/profiles_state.cc
+++ b/chrome/browser/profiles/profiles_state.cc
@@ -274,9 +274,6 @@ void RemoveBrowsingDataForProfile(const
@@ -314,9 +314,6 @@ void RemoveBrowsingDataForProfile(const
// The BrowsingDataRemover relies on many objects that aren't created in unit
// tests. Previously this code would depend on content::ResourceDispatcherHost
// but that's gone, so do a similar hack for now.
Expand All @@ -695,23 +695,23 @@
sources = [
"chrome_controller_client.cc",
"chrome_controller_client.h",
@@ -70,6 +71,7 @@ static_library("safe_browsing") {
@@ -71,6 +72,7 @@ static_library("safe_browsing") {
"//mojo/public/cpp/system",
"//services/preferences/public/cpp",
]
+ }

if (is_android) {
deps += [ "//chrome/browser/password_manager/android:utils" ]
@@ -512,6 +514,7 @@ static_library("advanced_protection") {
@@ -504,6 +506,7 @@ static_library("advanced_protection") {
}

source_set("metrics_collector") {
+ if (false) {
sources = [
"safe_browsing_metrics_collector_factory.cc",
"safe_browsing_metrics_collector_factory.h",
@@ -531,6 +534,7 @@ source_set("metrics_collector") {
@@ -523,6 +526,7 @@ source_set("metrics_collector") {
"//components/safe_browsing/core/common:safe_browsing_prefs",
"//content/public/browser",
]
Expand Down Expand Up @@ -808,7 +808,7 @@
- // These threat types are not currently associated with
- // interstitials, and thus resources with these threat types are
- // not ever whitelisted or pending whitelisting.
- NOTREACHED();
- NOTREACHED_IN_MIGRATION();
- break;
- }
- }
Expand All @@ -817,7 +817,7 @@

--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -5390,7 +5390,6 @@ static_library("ui") {
@@ -5413,7 +5413,6 @@ static_library("ui") {
"views/download/bubble/download_dialog_view.h",
"views/download/bubble/download_toolbar_button_view.cc",
"views/download/bubble/download_toolbar_button_view.h",
Expand All @@ -827,7 +827,7 @@
"views/download/download_item_view.cc",
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -501,22 +501,6 @@ void TabHelpers::AttachTabHelpers(WebCon
@@ -503,32 +503,6 @@ void TabHelpers::AttachTabHelpers(WebCon
// See https://crbug.com/910288.
resource_coordinator::ResourceCoordinatorTabHelper::CreateForWebContents(
web_contents);
Expand All @@ -842,6 +842,16 @@
- web_contents,
- safe_browsing::TailoredSecurityServiceFactory::GetForProfile(profile));
- }
- if (base::FeatureList::IsEnabled(
- safe_browsing::kSafeBrowsingAsyncRealTimeCheck) &&
- g_browser_process->safe_browsing_service()) {
- safe_browsing::AsyncCheckTracker::CreateForWebContents(
- web_contents, g_browser_process->safe_browsing_service()->ui_manager());
- }
- // SafeBrowsingTabObserver creates a ClientSideDetectionHost, which observes
- // events from PermissionRequestManager and AsyncCheckTracker in its
- // constructor. Therefore, PermissionRequestManager and AsyncCheckTracker need
- // to be created before SafeBrowsingTabObserver is created.
- safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(
- web_contents,
- std::make_unique<safe_browsing::ChromeSafeBrowsingTabObserverDelegate>());
Expand All @@ -852,15 +862,15 @@
SecurityStateTabHelper::CreateForWebContents(web_contents);
--- a/chrome/browser/ui/webui/downloads/downloads_dom_handler.cc
+++ b/chrome/browser/ui/webui/downloads/downloads_dom_handler.cc
@@ -26,7 +26,6 @@
@@ -25,7 +25,6 @@
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/download/bubble/download_bubble_ui_controller.h"
-#include "chrome/browser/download/download_danger_prompt.h"
#include "chrome/browser/download/download_history.h"
#include "chrome/browser/download/download_item_model.h"
#include "chrome/browser/download/download_item_warning_data.h"
@@ -292,13 +291,6 @@ void DownloadsDOMHandler::SaveDangerousR
@@ -291,13 +290,6 @@ void DownloadsDOMHandler::SaveDangerousR
}

CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_SAVE_DANGEROUS);
Expand All @@ -874,7 +884,7 @@
}

// "Suspicious" in this context applies to insecure as well as dangerous
@@ -569,12 +561,6 @@ void DownloadsDOMHandler::RemoveDownload
@@ -568,12 +560,6 @@ void DownloadsDOMHandler::RemoveDownload
IdSet ids;

for (download::DownloadItem* download : to_remove) {
Expand All @@ -887,7 +897,7 @@
DownloadItemModel item_model(download);
if (!item_model.ShouldShowInShelf() ||
download->GetState() == download::DownloadItem::IN_PROGRESS) {
@@ -783,54 +769,6 @@ void DownloadsDOMHandler::FinalizeRemova
@@ -782,54 +768,6 @@ void DownloadsDOMHandler::FinalizeRemova
}
}

Expand Down Expand Up @@ -973,7 +983,7 @@
void MaybeTriggerDownloadWarningHatsSurvey(
--- a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
+++ b/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
@@ -275,69 +275,6 @@ CreateHttpsOnlyModePage(content::WebCont
@@ -275,66 +275,6 @@ CreateHttpsOnlyModePage(content::WebCont
security_interstitials::https_only_mode::HttpInterstitialState{});
}

Expand All @@ -989,9 +999,6 @@
- request_url = GURL(url_param);
- }
- }
- GURL main_frame_url(request_url);
- // TODO(mattm): add flag to change main_frame_url or add dedicated flag to
- // test subresource interstitials.
- std::string type_param;
- if (net::GetValueForKeyInQuery(web_contents->GetVisibleURL(), "type",
- &type_param)) {
Expand All @@ -1013,7 +1020,7 @@
- primary_main_frame->GetGlobalId();
- safe_browsing::SafeBrowsingBlockingPage::UnsafeResource resource;
- resource.url = request_url;
- resource.is_subresource = request_url != main_frame_url;
- resource.is_subresource = false;
- resource.is_subframe = false;
- resource.threat_type = threat_type;
- resource.render_process_id = primary_main_frame_id.child_id;
Expand All @@ -1035,15 +1042,15 @@
- g_browser_process->safe_browsing_service()->ui_manager().get();
- return base::WrapUnique<security_interstitials::SecurityInterstitialPage>(
- ui_manager->CreateBlockingPage(
- web_contents, main_frame_url, {resource},
- web_contents, request_url, {resource},
- /*forward_extension_event=*/false,
- /*blocked_page_shown_timestamp=*/std::nullopt));
-}
-
std::unique_ptr<EnterpriseBlockPage> CreateEnterpriseBlockPage(
content::WebContents* web_contents) {
const GURL kRequestUrl("https://enterprise-block.example.net");
@@ -348,95 +285,6 @@ std::unique_ptr<EnterpriseBlockPage> Cre
@@ -345,94 +285,6 @@ std::unique_ptr<EnterpriseBlockPage> Cre
kRequestUrl));
}

Expand Down Expand Up @@ -1089,7 +1096,6 @@
- if (GURL(url_param).is_valid())
- request_url = GURL(url_param);
- }
- GURL main_frame_url(request_url);
- std::string type_param;
- bool is_giant_webview = false;
- if (net::GetValueForKeyInQuery(web_contents->GetVisibleURL(), "type",
Expand All @@ -1112,7 +1118,7 @@
- primary_main_frame->GetGlobalId();
- safe_browsing::SafeBrowsingBlockingPage::UnsafeResource resource;
- resource.url = request_url;
- resource.is_subresource = request_url != main_frame_url;
- resource.is_subresource = false;
- resource.is_subframe = false;
- resource.threat_type = threat_type;
- resource.render_process_id = primary_main_frame_id.child_id;
Expand All @@ -1133,13 +1139,13 @@
- return base::WrapUnique<TestSafeBrowsingBlockingPageQuiet>(
- TestSafeBrowsingBlockingPageQuiet::CreateBlockingPage(
- g_browser_process->safe_browsing_service()->ui_manager().get(),
- web_contents, main_frame_url, resource, is_giant_webview));
- web_contents, request_url, resource, is_giant_webview));
-}
-
#if BUILDFLAG(ENABLE_CAPTIVE_PORTAL_DETECTION)
std::unique_ptr<CaptivePortalBlockingPage> CreateCaptivePortalBlockingPage(
content::WebContents* web_contents) {
@@ -543,12 +391,8 @@ void InterstitialHTMLSource::StartDataRe
@@ -539,12 +391,8 @@ void InterstitialHTMLSource::StartDataRe
interstitial_delegate = CreateMITMSoftwareBlockingPage(web_contents);
} else if (path_without_query == "/blocked-interception") {
interstitial_delegate = CreateBlockedInterceptionBlockingPage(web_contents);
Expand All @@ -1152,7 +1158,7 @@
} else if (path_without_query == "/clock") {
interstitial_delegate = CreateBadClockBlockingPage(web_contents);
} else if (path_without_query == "/lookalike") {
@@ -563,12 +407,7 @@ void InterstitialHTMLSource::StartDataRe
@@ -559,12 +407,7 @@ void InterstitialHTMLSource::StartDataRe
interstitial_delegate = CreateHttpsOnlyModePage(web_contents);
}

Expand All @@ -1174,11 +1180,11 @@
#include "components/safe_browsing/buildflags.h"
-#include "components/safe_browsing/content/renderer/threat_dom_details.h"
#include "components/spellcheck/spellcheck_buildflags.h"
#include "components/subresource_filter/content/renderer/safe_browsing_unverified_ruleset_dealer.h"
#include "components/subresource_filter/content/renderer/subresource_filter_agent.h"
#include "components/subresource_filter/content/renderer/unverified_ruleset_dealer.h"
@@ -465,12 +464,8 @@ void ChromeContentRendererClient::Render
subresource_filter_ruleset_dealer_ =
std::make_unique<subresource_filter::UnverifiedRulesetDealer>();
@@ -459,12 +458,8 @@ void ChromeContentRendererClient::Render
subresource_filter_ruleset_dealer_ = std::make_unique<
subresource_filter::SafeBrowsingUnverifiedRulesetDealer>();

- phishing_model_setter_ =
- std::make_unique<safe_browsing::PhishingModelSetterImpl>();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
--- a/components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_manager.cc
+++ b/components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_manager.cc
@@ -802,95 +802,6 @@ std::tuple<GURL, std::string> AutofillCr
@@ -832,93 +832,6 @@ std::tuple<GURL, std::string> AutofillCr
}

bool AutofillCrowdsourcingManager::StartRequest(FormRequestData request_data) {
Expand All @@ -10,9 +10,12 @@
- // NavigationRequest. Not setting an IsolationInfo is safe because no
- // information about the response is passed to the renderer, or is otherwise
- // visible to a page. See crbug/1176635#c22.
-#if BUILDFLAG(IS_IOS)
- DCHECK(!request_data.isolation_info);
-#else
- DCHECK((request_data.request_type == RequestType::kRequestUpload) ==
- !request_data.isolation_info);
-
-#endif
- // Get the URL and method to use for this request.
- auto [request_url, method] = GetRequestURLAndMethod(request_data);
-
Expand All @@ -29,17 +32,12 @@
- resource_request->credentials_mode = network::mojom::CredentialsMode::kOmit;
- resource_request->method = method;
-
- // On iOS we have a single, shared URLLoaderFactory provided by BrowserState.
- // As it is shared, it is not trusted and we cannot assign trusted_params
- // to the network request.
-#if !BUILDFLAG(IS_IOS)
- if (request_data.isolation_info) {
- resource_request->trusted_params =
- network::ResourceRequest::TrustedParams();
- resource_request->trusted_params->isolation_info =
- *request_data.isolation_info;
- }
-#endif
-
- // Add Chrome experiment state to the request headers.
- variations::AppendVariationsHeaderUnknownSignedIn(
Expand Down
Loading

0 comments on commit 3745260

Please sign in to comment.