Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcs update #1633

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Dcs update #1633

merged 3 commits into from
Dec 7, 2023

Conversation

theNerd247
Copy link
Contributor

updates dcs-branch-merger to 1.4.1

@elsylambert
Copy link
Contributor

@Joel-C-Johnson Can you update this?

@elsylambert
Copy link
Contributor

@RevantCI Please test the case where you found the problem in branch merge.

@Joel-C-Johnson
Copy link
Collaborator

@Joel-C-Johnson Can you update this?

I have tested the issue with @LijuJacob08 locally with 1.4.1 (dcs-branch-merger rcl ), and we didn't face the issue. I have put a comment on the issue regarding it. #1609 (comment)

@RevantCI
Copy link
Collaborator

RevantCI commented Dec 7, 2023

@RevantCI Please test the case where you found the problem in branch merge.

Hi Elsy, had asked Joel to test and comment about the issue in the #1609 dcs merge conflict issue.
Here is the link to the comment where Joel has explained it. #1609 (comment)

@Joel-C-Johnson
Copy link
Collaborator

Resolved the PR conflicts.
Then me and @RevantCI tested with deploy preview link it's working fine for different books but same books same row changes its showing conflicts as expected.
Merging the PR.

@Joel-C-Johnson Joel-C-Johnson merged commit e8671df into develop Dec 7, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants