Skip to content

Commit

Permalink
Remove .binder information, fix demo notebook "solver_name" issues (#261
Browse files Browse the repository at this point in the history
)

binder is better launched from a separate repository which pulls in the
code on demand. This is much faster because of the heavy dependencies.
  • Loading branch information
lmoresi authored Nov 4, 2024
2 parents 7797dd0 + cac5df0 commit c3d8d40
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 107 deletions.
8 changes: 0 additions & 8 deletions .binder/apt.txt

This file was deleted.

31 changes: 0 additions & 31 deletions .binder/environment.yml

This file was deleted.

46 changes: 0 additions & 46 deletions .binder/postBuild

This file was deleted.

8 changes: 0 additions & 8 deletions .binder/start

This file was deleted.

5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ The `underworld3` module (API) documentation can be found online:

## Binder demonstration version

Main Branch: [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/underworldcode/underworld3/main)
Main Branch: [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/underworldcode/underworld3/main)

Development Branch: [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/underworld-community/uw3-demo-launcher/HEAD?labpath=docs%2Fuser%2FNotebooks%2FNotebook_Index.ipynb)

Development Branch: [![Binder](https://mybinder.org/badge_logo.svg)](https://mybinder.org/v2/gh/underworldcode/underworld3/development)

## Installation Guide

Expand Down
2 changes: 1 addition & 1 deletion docs/user/Notebooks/1-Meshes.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion docs/user/Notebooks/2-Variables.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion docs/user/Notebooks/3-Symbolic_Forms.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
2 changes: 1 addition & 1 deletion docs/user/Notebooks/4-Solvers.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
4 changes: 3 additions & 1 deletion docs/user/Notebooks/5-Solvers.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,9 @@
"p_soln = uw.discretisation.MeshVariable(\"p\", meshball, 1, degree=1, continuous=True)\n",
"\n",
"stokes = uw.systems.Stokes(\n",
" meshball, velocityField=v_soln, pressureField=p_soln, solver_name=\"stokes\"\n",
" meshball, \n",
" velocityField=v_soln, \n",
" pressureField=p_soln,\n",
")\n",
"\n",
"stokes.constitutive_model = uw.constitutive_models.ViscousFlowModel\n",
Expand Down
8 changes: 4 additions & 4 deletions docs/user/Notebooks/6-Timestepping.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@
"outputs": [],
"source": [
"stokes = uw.systems.Stokes(\n",
" meshball, velocityField=v_soln, pressureField=p_soln, solver_name=\"stokes\"\n",
" meshball, velocityField=v_soln, \n",
" pressureField=p_soln,\n",
")\n",
"\n",
"stokes.bodyforce = rayleigh_number * t_soln.sym * unit_rvec\n",
Expand Down Expand Up @@ -164,7 +165,6 @@
" meshball,\n",
" u_Field=t_soln,\n",
" V_fn=v_soln,\n",
" solver_name=\"adv_diff\",\n",
" order=2,\n",
" verbose=False,\n",
")\n",
Expand Down Expand Up @@ -468,7 +468,7 @@
"Based on our previous notebook, can you see how to calculate and (if necessary) remove rigid-body the rotation \n",
"null-space from the solution ? \n",
"\n",
"The use of a coarse-level singular-value decomposition for the velocity solver should help, here, but it's wise to \n",
"The use of a coarse-level singular-value decomposition for the velocity solver should help, in this case, but it's wise to \n",
"check anyway.\n",
"\n",
"```python\n",
Expand Down Expand Up @@ -519,7 +519,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
3 changes: 1 addition & 2 deletions docs/user/Notebooks/7-Unsteady_Flow.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@
" mesh, \n",
" velocityField=v_soln, \n",
" pressureField=p_soln, \n",
" solver_name=\"Navier_stokes\",\n",
" rho=reynolds_number,\n",
" order=1,\n",
")\n",
Expand Down Expand Up @@ -471,7 +470,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.9"
"version": "3.11.10"
}
},
"nbformat": 4,
Expand Down
1 change: 0 additions & 1 deletion docs/user/Notebooks/8-Particle_Swarms.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,6 @@
" mesh, \n",
" velocityField=v_soln, \n",
" pressureField=p_soln, \n",
" solver_name=\"Stokes\",\n",
")\n",
"\n",
"stokes.bodyforce = sympy.Matrix((0,0))\n",
Expand Down

0 comments on commit c3d8d40

Please sign in to comment.