-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNDERTOW-2523] Prepare for Jakarta Servlet 6.1 #1702
Open
jamezp
wants to merge
3
commits into
undertow-io:main
Choose a base branch
from
jamezp:jakarta-servlet-6.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamezp
force-pushed
the
jakarta-servlet-6.1
branch
4 times, most recently
from
November 5, 2024 15:55
d618c68
to
d0773d8
Compare
jamezp
force-pushed
the
jakarta-servlet-6.1
branch
from
November 5, 2024 23:46
d0773d8
to
76737e9
Compare
jamezp
changed the title
Prepare for Jakarta Servlet 6.1
[UNDERTOW-2523] Prepare for Jakarta Servlet 6.1
Nov 5, 2024
jamezp
force-pushed
the
jakarta-servlet-6.1
branch
from
November 5, 2024 23:50
76737e9
to
b6fae03
Compare
fl4via
approved these changes
Nov 21, 2024
jamezp
force-pushed
the
jakarta-servlet-6.1
branch
from
December 3, 2024 21:04
b6fae03
to
b0c4fa6
Compare
fl4via
approved these changes
Dec 4, 2024
fl4via
added
next release
This PR will be merged before next release or has already been merged (for payload double check)
new feature/API change
New feature to be introduced or a change to the API (non suitable to minor releases)
labels
Dec 4, 2024
I've merged #1713 into this branch too. Once the other PR is merged, I can update this branch to reflect that. However, I wanted to get a CI run in to validate it. |
…a priority of 1 as there is a matching ExchangeAttribute in the core module. https://issues.redhat.com/browse/UNDERTOW-2538 Signed-off-by: James R. Perkins <[email protected]>
N.B. We also need to augment the Session SPI to facilitate a proper implementation of HttpSession.getAccessor(), but this can go in afterwards (with a trivial default implementation). |
…ta Servlet 6.1 https://issues.redhat.com/browse/UNDERTOW-2523 Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
jakarta-servlet-6.1
branch
from
January 14, 2025 01:38
dcd6c17
to
79669fc
Compare
jasondlee
reviewed
Jan 14, 2025
core/src/main/java/io/undertow/attribute/SecureProtocolAttribute.java
Outdated
Show resolved
Hide resolved
…ervlet 6.1. Note this changed the Cookie specification to RFC 6265 which required test changes. https://issues.redhat.com/browse/UNDERTOW-2523 Signed-off-by: James R. Perkins <[email protected]>
jamezp
force-pushed
the
jakarta-servlet-6.1
branch
from
January 14, 2025 15:08
79669fc
to
d7b2f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new feature/API change
New feature to be introduced or a change to the API (non suitable to minor releases)
next release
This PR will be merged before next release or has already been merged (for payload double check)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial updates to support Jakarta Servlet 6.1. This not complete and the changes since 6.0 need to be reviewed.
This passes the current 6.1 TCK, but will fail the upstream TCK if built from source. I'll discuss the details on chat.
https://issues.redhat.com/browse/UNDERTOW-2523