Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2523] Prepare for Jakarta Servlet 6.1 #1702

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jamezp
Copy link
Contributor

@jamezp jamezp commented Oct 31, 2024

This is the initial updates to support Jakarta Servlet 6.1. This not complete and the changes since 6.0 need to be reviewed.

This passes the current 6.1 TCK, but will fail the upstream TCK if built from source. I'll discuss the details on chat.

https://issues.redhat.com/browse/UNDERTOW-2523

@jamezp jamezp force-pushed the jakarta-servlet-6.1 branch 4 times, most recently from d618c68 to d0773d8 Compare November 5, 2024 15:55
@jamezp jamezp marked this pull request as ready for review November 5, 2024 21:13
@jamezp jamezp force-pushed the jakarta-servlet-6.1 branch from d0773d8 to 76737e9 Compare November 5, 2024 23:46
@jamezp jamezp changed the title Prepare for Jakarta Servlet 6.1 [UNDERTOW-2523] Prepare for Jakarta Servlet 6.1 Nov 5, 2024
@jamezp jamezp force-pushed the jakarta-servlet-6.1 branch from 76737e9 to b6fae03 Compare November 5, 2024 23:50
@jamezp jamezp force-pushed the jakarta-servlet-6.1 branch from b6fae03 to b0c4fa6 Compare December 3, 2024 21:04
@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) labels Dec 4, 2024
@jamezp
Copy link
Contributor Author

jamezp commented Jan 7, 2025

I've merged #1713 into this branch too. Once the other PR is merged, I can update this branch to reflect that. However, I wanted to get a CI run in to validate it.

…a priority of 1 as there is a matching ExchangeAttribute in the core module.

https://issues.redhat.com/browse/UNDERTOW-2538
Signed-off-by: James R. Perkins <[email protected]>
@pferraro
Copy link
Contributor

N.B. We also need to augment the Session SPI to facilitate a proper implementation of HttpSession.getAccessor(), but this can go in afterwards (with a trivial default implementation).

@jamezp jamezp force-pushed the jakarta-servlet-6.1 branch from dcd6c17 to 79669fc Compare January 14, 2025 01:38
@jamezp
Copy link
Contributor Author

jamezp commented Jan 14, 2025

I closed #1713 in favor of #1714 and included that commit in this PR.

…ervlet 6.1. Note this changed the Cookie specification to RFC 6265 which required test changes.

https://issues.redhat.com/browse/UNDERTOW-2523
Signed-off-by: James R. Perkins <[email protected]>
@jamezp jamezp force-pushed the jakarta-servlet-6.1 branch from 79669fc to d7b2f72 Compare January 14, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants