Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2436] fix HttpServerExchange state flag race conditions #1661

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

aogburn
Copy link
Contributor

@aogburn aogburn commented Sep 5, 2024

@aogburn
Copy link
Contributor Author

aogburn commented Sep 5, 2024

This is taking an approach equivalent to the UNDERTOW-1158 fix for the ServletInputStream state race conditions

@ropalka ropalka added the bug fix Contains bug fix(es) label Sep 11, 2024
@fl4via fl4via added the under verification Currently being verified (running tests, reviewing) before posting a review to contributor label Sep 18, 2024
@fl4via
Copy link
Member

fl4via commented Sep 18, 2024

I am verifying this with a reproducer in a standalone application. Soon I'll update it with the results so it can be merged. The failures are not caused by this request and will be addressed in a separate PR I'll be submitting soon.

@fl4via fl4via added waiting CI check Ready to be merged but waiting for CI check and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Oct 4, 2024
@fl4via
Copy link
Member

fl4via commented Oct 4, 2024

Ci is fixed, we will be merging this one as soon as CI passes (which hopefully is the case now)

@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) and removed waiting CI check Ready to be merged but waiting for CI check labels Oct 4, 2024
@fl4via fl4via merged commit 9a10ac4 into undertow-io:main Oct 4, 2024
11 checks passed
@aogburn aogburn deleted the 03917716main branch October 4, 2024 11:20
@aogburn
Copy link
Contributor Author

aogburn commented Oct 4, 2024

Thanks @fl4via !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Contains bug fix(es)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants