Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1748] add comment line to predicates #1642

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[UNDERTOW-1748] add comment line to predicates #1642

merged 1 commit into from
Oct 4, 2024

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb added under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) waiting peer review PRs that edit core classes might require an extra review labels Jul 18, 2024
@baranowb baranowb requested review from ropalka and fl4via July 18, 2024 07:51
@baranowb
Copy link
Contributor Author

CI failure is known unstability.

@ropalka
Copy link
Contributor

ropalka commented Sep 11, 2024

@fl4via please review

@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Oct 4, 2024
@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) and removed waiting peer review PRs that edit core classes might require an extra review labels Oct 4, 2024
@fl4via fl4via force-pushed the UNDERTOW-1748_main branch from d32d4de to efbb64c Compare October 4, 2024 09:37
@fl4via fl4via removed the under verification Currently being verified (running tests, reviewing) before posting a review to contributor label Oct 4, 2024
@fl4via fl4via merged commit 7578625 into undertow-io:main Oct 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl4via fl4via fl4via approved these changes

@ropalka ropalka ropalka approved these changes

Assignees
No one assigned
Labels
new feature/API change New feature to be introduced or a change to the API (non suitable to minor releases) next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baranowb @ropalka @fl4via