Mailman Tweaks #192
Merged
Mailman Tweaks #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning might fail if the requested tag does not exist, but we should handle that possibility gracefully and just return an error instead of bubbling an exception up to the caller.
If parsing the email fails (e.g. UtfDecodeError) we want to still record the attempt in the database so that it at least appears on the submission dashboard.
It is useful to have a tag for a submission even if it is basically completely bogus. We should try to make a tag as soon as possible.
The log is filled with the messages from this git advice. We do not need this advice in a noninteractive context so just shut it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small changes to mailman to improve the output and make it more robust