Dashboard overhaul #186
Merged
Dashboard overhaul #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
Closed
Closed
Closed
To make way for a more proper dashboard that shows the grades, we should move the old dashboard that shows all submission activity to a new url
fixes a flake8 error; improves legibility.
Lists all assignments with placeholder table headings.
Right now the post request handler just logs which assignment the oopsie was requested for.
Add a page that sits between clicking the oopsie button and actually using the oopsie where the student can think twice.
also the oopsie table will be keeping track of the time stamp it recieves the oopsie at: the user won't ever need this info but it might be useful for administrative reasons.
verify that the provided assignment is valid and that it is not too late to use an oopsie for that assignment, and then once the student confirms, record their request in the database.
We will want to add more complexity and doing it inline would make the HTML code unwieldy.
Determine 'oopsieness' and store that value in each assignment table. This value is used to change how the oopsie button is generated.
add more table header entries to represent the fields that will be in an assignment submission, and introduce a new function to generate a row for a submission, and use to create one for the initial submission.
Use the gradeable row function to create rows for the peer reivew and and final submission along with the other components of the full table layout.
If an oopsie was used, do not show the initial submission or peer review fields to the user for that particular assignment.
The main submission table is filled with every 'email event' that mailman sees, the gradeable table is the place for keeping track of all submissions that on the surface appear to be 'good' submissions: they are addressed to the correct emails, they are submitted within the expected submission windows, etc.
This will record the fate of the submission during mailman's processing If this submission is ineligible for grading, this field will hold the reason why. If it is an eligible submission, this field will explain what the mailman thinks it is.
This lays the groundwork for future mailman processing that will recognize valid submission attempts and provide useful feedback to the user.
charliemirabile
force-pushed
the
bashdoard
branch
from
72c8f1a to
11b68f7
Compare
Merged
theyoyojo
reviewed
Oct 15, 2024
theyoyojo
reviewed
Oct 15, 2024
Update the submission's status to reflect this processing
Update the submission's status to reflect this processing
The table now handles the possibility that there are any number of peer review assignments between 0 and 2.
If a submission is provided (currently none is - all callsites just pass None) the table displays the timestamp and submission ID.
until the student makes an initial submission and the initial submission deadline has passed, it does not make sense to display all the rows of the table, because the peer review will not be filled in, and the student may not be eligle for making a final submission if they do not make an initial one.
charliemirabile
force-pushed
the
bashdoard
branch
from
11b68f7 to
8341650
Compare
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After one year, we have finally surpassed what we had for a dashboard