Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denis: initial: update query to reflect new schema #164

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

charliemirabile
Copy link
Contributor

the assignment field in the submissions table no longer exists having been replaced by recipient to accomodate peer reviews.

Fixes: 60d73a7 ("mailman: unify all submissions under common table for dashboard")

the assignment field in the submissions table no longer exists having
been replaced by recipient to accomodate peer reviews.

Fixes: 60d73a7 ("mailman: unify all submissions under common table for dashboard")
The schema needs to be able to handle one or both of the reviwees being
null, and the code that inserts into the DB needs to account for lists
that are not exactly 3 elements long.

Fixes: 86353ae ("denis: record peer reveiew assignments")
Copy link
Contributor

@michael-burke4 michael-burke4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michael-burke4 michael-burke4 merged commit 3fd0a25 into master Sep 23, 2024
@michael-burke4 michael-burke4 deleted the denis_fix branch September 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants