Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ja contents #483

Merged
merged 17 commits into from
Jan 31, 2024
Merged

Add ja contents #483

merged 17 commits into from
Jan 31, 2024

Conversation

yk-saito
Copy link
Contributor

@yk-saito yk-saito commented Dec 8, 2023

変更内容

背景

備考

@yk-saito yk-saito added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 8, 2023
@yk-saito yk-saito self-assigned this Dec 8, 2023
@yk-saito
Copy link
Contributor Author

yk-saito commented Dec 8, 2023

Hi, @kmjones1979

In the section-1/lesson-2 Updating your subgraph there is a mention of a "good link to the docs for that," but the specific link was not included:

Screenshot 2023-12-08 at 14 13 24

Could the following link be the correct reference for the section on entities?
https://thegraph.com/docs/en/developing/creating-a-subgraph/#defining-entities

Copy link
Contributor

@kmjones1979 kmjones1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@kmjones1979 kmjones1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@yk-saito yk-saito marked this pull request as ready for review January 31, 2024 09:05
@yk-saito yk-saito merged commit 1171812 into feature/add-thegraph Jan 31, 2024
4 checks passed
@yk-saito yk-saito deleted the feature/add-thegraph-ja branch January 31, 2024 09:07
@yk-saito yk-saito changed the title [WIP] Add ja contents Add ja contents Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants