Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86 bug stormrgetdatainterpolate fails with fractional time difference between initial storm readings #88

Conversation

thomasarsouze
Copy link
Contributor

Solves #86

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 89.77273% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 70.31%. Comparing base (7882a0e) to head (7823cab).
Report is 3 commits behind head on master.

Files Patch % Lines
R/spatialBehaviour.R 90.00% 8 Missing ⚠️
R/temporalBehaviour.R 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   70.53%   70.31%   -0.23%     
==========================================
  Files           8        8              
  Lines        1663     1664       +1     
==========================================
- Hits         1173     1170       -3     
- Misses        490      494       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasarsouze thomasarsouze merged commit 68fa15e into master May 7, 2024
9 checks passed
@thomasarsouze
Copy link
Contributor Author

bugfix:

  • handles when time steps between two observations is fractional hours
    improvments:
  • handles irregular observation times
  • handles observations at shorter intervals than interpolation

@thomasarsouze thomasarsouze deleted the 86-bug-stormrgetdatainterpolate-fails-with-fractional-time-difference-between-initial-storm-readings branch May 7, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: StormR:::getDataInterpolate fails with fractional time difference between initial storm readings
1 participant