Skip to content

Commit

Permalink
fix(qiankun): should remove internal cache of loadMicroApp while load…
Browse files Browse the repository at this point in the history
…ing failed
  • Loading branch information
kuitos committed Mar 5, 2024
1 parent 9c56910 commit 2bcea51
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion packages/qiankun/src/apis/loadMicroApp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,21 @@ export function loadMicroApp<T extends ObjectType>(

const parcelConfigObjectGetterPromise = loadApp(app, userConfiguration, lifeCycles);

let parcelConfigObjectGetter: ParcelConfigObjectGetter | undefined;

if (containerXPath) {
const appContainerXPathKey = getContainerXPathKey(containerXPath);
appConfigPromiseGetterMap.set(appContainerXPathKey, parcelConfigObjectGetterPromise);
try {
parcelConfigObjectGetter = await parcelConfigObjectGetterPromise;
} catch (e) {
appConfigPromiseGetterMap.delete(appContainerXPathKey);
throw e;
}
}

return (await parcelConfigObjectGetterPromise)(container);
parcelConfigObjectGetter = parcelConfigObjectGetter || (await parcelConfigObjectGetterPromise);
return parcelConfigObjectGetter(container);
};

if (!started) {
Expand Down

0 comments on commit 2bcea51

Please sign in to comment.