This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
POC: Swap 'Doc Type Picker' with List View's layout control #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dnwhte! 🎉 I'll review this very soon - excited to try it out! |
leekelleher
suggested changes
Jan 28, 2019
There was a problem hiding this comment.
@dnwhte Overall, I'm loving this feature, feels much more "Umbraco" than the previous dropdown lists.
I've left a few comment, mostly UI/UX/polish. Let me know what you think.
Thanks again!
...r.Umbraco.InnerContent/Web/UI/App_Plugins/InnerContent/views/innercontent.doctypepicker.html
Outdated
Show resolved
Hide resolved
...r.Umbraco.InnerContent/Web/UI/App_Plugins/InnerContent/views/innercontent.doctypepicker.html
Outdated
Show resolved
Hide resolved
...r.Umbraco.InnerContent/Web/UI/App_Plugins/InnerContent/views/innercontent.doctypepicker.html
Outdated
Show resolved
Hide resolved
src/Our.Umbraco.InnerContent/Web/UI/App_Plugins/InnerContent/js/innercontent.js
Show resolved
Hide resolved
src/Our.Umbraco.InnerContent/Web/UI/App_Plugins/InnerContent/js/innercontent.js
Outdated
Show resolved
Hide resolved
added 10 commits
July 25, 2019 16:22
Attempt to use env variables in cmd Fix typo Attempt to pass variables to cmd Pass env variables to cmd Set variables instead of just echo TYPO Echo out variable values Try echoing values of set variables Try using BuildId Remove spaces from variable sets Add suffix Add LCSC as suffix Publish artifacts
|
@leekelleher all conversation items have been resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC PR for #24.