Reverting source_file_path back to value it was in 3.2. #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 23, 2023 10:03
Now both source_file and source_file_path will be set
embedder-solr unittest is disabled. When fixed the unittest will be active.
response record. The request record would result in this log. For WARC-files with 50.000 response records , it would give 50000 log lines.
|
Sorry for not getting to that. The reason I didn't accept it earlier is that the Hadoop version needs updating to match. But given it's probably going to be a while before that is needed (if at all) it probably doesn't matter. |
|
No longer your problem, Andy! Just another thing I'll have to get a handle on :o) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now both source_file and source_file_path will be set as it was 3.2.
By mistake both values was put into source_file giving it the wrong value and leaving out source_file_path empty.