Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third reconciliation PR from production/RRFS.v1 #229

Draft
wants to merge 21 commits into
base: ufs/dev
Choose a base branch
from

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 29, 2024

This work is the same as #179, but targeting ufs/dev.

This PR is the first of many that will modernized, modularize, and streamline Thompson-Eidhammer microphysics.

This PR includes:

  1. The addition of parameterized kind: REAL -> real(kind_phys)
  2. Consistent indentation
  3. Removal of GOTO statements
  4. Physical constants are now coming from the host.

This is expected to change results for any RTs that use Thompson MP because of point 4.

AndersJensen-NOAA and others added 21 commits December 7, 2023 14:01
…nd it will be consistent with convective precipitation"
…entrations.F90 due to passing in PI as variable
[production/RRFS.v1] physics updates for RRFS.v1 code freeze
…_alloc_RRFS

[production/RRFS.v1] Fix 'check all' with 0-size allocations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants