Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Intel LLVM on Hera, Orion and Hercules #996

Draft
wants to merge 48 commits into
base: develop
Choose a base branch
from
Draft

Port to Intel LLVM on Hera, Orion and Hercules #996

wants to merge 48 commits into from

Conversation

GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA commented Nov 4, 2024 •
edited
Loading

DESCRIPTION OF CHANGES:

Port to Intel LLVM on Hera, Orion and Hercules. Keep the Intel Classic as an option on those machines.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel Classic (Orion, Jet, Hera, Hercules and WCOSS2). Done on Hera using 7efdbed.
  • Compile branch on Orion, Hera and Hercules using Intel LLVM. Done using 7efdbed.
  • Compile branch on Hera using GNU. Done using 7efdbed.
  • Compile branch in 'Debug' mode on WCOSS2.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using 7efdbed (Intel LLVM).
  • Run relevant consistency tests locally on all Tier 1 machines.

Additional tests performed. Those on Hera, Orion and Hercules used Intel LLVM.

  • Test gdas_init utility on Hera. Successfully done using 7efdbed with a 2024/11/01/06z GFS test case.
  • Test sfc_climo_gen utility on Hera and WCOSS2. Successfully done on Hera using 7efdbed.
  • Test weight_gen utility on Hera, Orion and Hercules. Successfully tested using 7efdbed.
  • Create a global C96 model grid using the scripts in ./driver_scripts on Hera, Orion and Hercules. Successfully done using 7efdbed.

DEPENDENCIES:

None.

DOCUMENTATION:

N/A

ISSUE:

Fixes #879.

George Gayno and others added 30 commits August 12, 2024 15:11
Updates to build emcsfc_snow2mdl with intelLLVM.
8ace80f 
Fixes ufs-community#879.
Updates to build weight_gen using intelLLVM.
8b2e37c 
Fixes ufs-community#879.
Updates to vcoord_gen to build with IntelLLVM.
6b44404 
Fixes ufs-community#879.
Update the ocnice_prep compilation to use intelLLVM.
5e262ce 
Fixes ufs-community#879.
Update chgres and cpld_gridgen builds to use intelLLVM.
28c90a1 
Fixes ufs-community#879.
Update glbevents and global_cycle builds to use
b56fe41 
IntelLLVM.

Fixes ufs-community#879.
Update build for sfc_climo_gen and grid_tools.
e87daf5 
Fixes ufs-community#879.
Update build for the orography related codes.
ab25159 
Fixes ufs-community#879.
Update ocean_merge compilation.
3228025 
Fixes ufs-community#879.
Turn on compilation of fvcom_tools.
76c137a 
Fixes ufs-community#879.
Minor source code updates to fre-nctools to eliminate
82bfcd8 
compiler warnings.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update build module on Orion.
8a50fb0 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update Orion build to match UFSWM.
13f8bc0 
Fixes ufs-community#879.
Update hercules build to match UFSWM.
4737e07 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update hera build module following the example of the
baf6edd 
UFSWM.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update build for unit tests.
e23e79c 
Fixes ufs-community#879.
Update fvcom_tools build for IntelLLVM.
97d8e44 
Fixes ufs-community#879.
Update main CMakeLists.txt to set 'C' compiler options.
1056ef5 
Fixes ufs-community#879.
Update ubuntu_intel.yaml workflow file to use IntelLLVM.
c10e85a 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Merge branch 'develop' into intelLLVM
9511885 
Fixes ufs-community#879.
Update speck build.
56bf5e1 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Change definitions of CC and FC.
98f840a 
Fixes ufs-community#879.
Merge branch 'develop' into intelLLVM
2bd0801 
Fixes ufs-community#879.
Merge branch 'develop' into intelLLVM
7dff2c3 
Fixes ufs-community#879.
Update the orog unit test build for IntelLLVM.
c1524bc 
Fixes ufs-community#879.
Merge branch 'develop' into intelLLVM
a2b8b4f 
Fixes ufs-community#879.
Update spack.yaml to use sigio v2.3.3, which as updated
0147b59 
to use oneapi.

Fixes ufs-community#879.
Rename hercules build module so both the new and old
082fb20 
intel compilers may be used.

Fixes ufs-community#879.
Add back the intel classic build module for hercules.
9a4ae70 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Rename orion build module to reflect new compiler.
948331c 
Fixes ufs-community#879.
GeorgeGayno-NOAA and others added 18 commits October 22, 2024 15:23
@GeorgeGayno-NOAA
Add back intel classic build module for orion.
dfb8730 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Remove sfcio library from spack.yaml as it is not used
a4136eb 
by the unit tests.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Add diagnostic print to chgres_cube test.
f47f84d 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Increase error threshold for the chgres/ftst_read_atm_grib2.F90
6c57bf9 
check of pressure.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Rename hera build module as intelllvm.
b2e987b 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Add back hera intel classic build modules.
ba8d241 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Remove some references to intel classic in workflow files.
8ae6efa 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Add logic to build_all.sh script to default to Intel classic
4c6d932 
if Intel LLVM is not available.

Fixes ufs-community#879.
Correct bug in build_all.sh.
addccd3 
Fixex ufs-community#879.
Update grid driver scripts to use intelLLVM and Hercules,
203b2de 
Orion and Hera.

Fixes ufs-community#879.
Update the weight_gen utility driver scripts on Hercules,
2d44d8b 
Hera and Orion to default to intelLLVM.

Fixes ufs-community#879.
Update the gdas_init utility driver scrip on Hera to use
31c62bd 
intelLLVM.

Fixes ufs-community#879.
Update the hercules regression test scripts to load the intelLLVM
3fa0aa5 
module.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update module load in the sfc_climo_gen utility.
1211785 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update the intelLLVM version 2024 on Hera.
2324720 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update regression test scripts to default to intelLLVM.
adf1650 
Fixes ufs-community#879.
@GeorgeGayno-NOAA
Modify the "-check all" compiler option for intelLLVM as
f1532e5 
on Hera it caused a compilation error when choosing
'debug' mode.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Update Orion regresson test driver scripts to default to
7efdbed 
intel LLVM.

Fixes ufs-community#879.
@GeorgeGayno-NOAA
Copy link
Collaborator Author

GeorgeGayno-NOAA commented Nov 4, 2024 •
edited
Loading

All consistency tests were run on Hera using 7efdbed and Intel LLVM.

  • The global_cycle, ice_blend, snow2mdl and weight_gen tests all passed.
  • chgres_cube tests 1, 2, 4, 5, 6, 7, 8, 9, 10, 11 and 12 failed. Differences from the baseline were 'roundoff' in magnitude.
  • cpld_griden and ocnice_prep failed. Will contact Denise for review.
  • grid_gen tests 1, 2, 3, 6, 7. Differences from the baseline were 'roundoff' in magnitude.

@GeorgeGayno-NOAA
Copy link
Collaborator Author

GeorgeGayno-NOAA commented Nov 5, 2024 •
edited
Loading

All consistency tests were run on Hercules and Orion using 7efdbed and Intel LLVM. Results were the same on both machines.

  • The ice_blend, global_cycle, ocnice_prep, snow2mdl and weight_gen tests all passed.
  • grid_gen tests 1, 2, 3, 6 and 7 failed.
  • chgres_cube tests 6, 7 and 11 failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Intel LLVM compilers
1 participant
@GeorgeGayno-NOAA