Use ufo_find to reduce code duplication in the cmake find modules #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re the use of the src/libs/zlib dir if no system wide installation was found
…g the built-in libs
|
@mgerhardy Are you awaiting something from me ? |
|
@hwoarangmy no - this is just a starting point for doing some more work on the cmake build system. You are welcome to step in, but I will continue when time allows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this pull request is to
a) use pkg-config for nix based systems
b) use built-in versions in src/libs/ automatically if not found via ufo_find (therefore the names of the ufo_find lib must match the name in the src/libs dir of the external dependency) This needs more work - this pr should just prepare this.
c) reduce code duplication for the Find.cmake modules