Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Fix visible vim-vixem iframe #1444

Closed
wants to merge 1 commit into from
Closed

Fix visible vim-vixem iframe #1444

wants to merge 1 commit into from

Conversation

caribpa
Copy link

@caribpa caribpa commented Aug 18, 2022

Hi!

This PR fixes #1424 and #1433.

I'm not sure if there is a reason for the vim-vixem iframe height to be updated on resize but nothing seems to be broken in my tests when ignoring it:

resize(_width: number, height: number): void {
const ele = document.getElementById("vimvixen-console-frame");
if (!ele) {
return;
}
ele.style.height = `${height}px`;
}

Let me know what you think 😁

@sewe2000
Copy link

Any progress on merging it?

@AnyTimeTraveler
Copy link

I just compiled it myself and tested it.
With this change, it's now no longer possible to open the command window at the bottom with :

@aleksandrs-ledovskis
Copy link

There already exists older PR (#1437). So, seemingly this PR is duplicate.

@caribpa
Copy link
Author

caribpa commented Aug 24, 2022

Whoops, somehow I missed #1437, which seems to be a proper fix and not break : 😅

Closing!

@caribpa caribpa closed this Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White Vim Vixen Console frame always visible at bottom of GitHub pages
4 participants