Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double quotes in cli #2499

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Fix double quotes in cli #2499

merged 4 commits into from
Jul 14, 2023

Conversation

zbeyens
Copy link
Member

@zbeyens zbeyens commented Jul 14, 2023

Description

See changesets.

Fixes #2484

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: bbdbc89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@udecode/plate-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2023 1:15pm

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 14, 2023

AI-Generated Summary: This pull request introduces minor changes to the code base by modifying the way strings are quoted in the code. Specifically, it changes the use of double quotes to single quotes in the files located at packages/cli/src/utils/transformers/transform-css-vars.ts and packages/cli/src/utils/transformers/transform-rsc.ts. Furthermore, the condition which checks both single and double quoted "use client" strings in transform-rsc.ts has been simplified to only check for a single quoted "use client" string. A changeset is also added as a part of this request, which labels the updates as a patch for '@udecode/plate-ui' and provides a brief summary regarding the implementation of single quotes instead of double.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 14, 2023
@ghost
Copy link

ghost commented Jul 14, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@reviewpad reviewpad bot added large Pull request is large and removed small Pull request is small labels Jul 14, 2023
@zbeyens zbeyens merged commit 603e6cd into main Jul 14, 2023
7 checks passed
@zbeyens zbeyens deleted the fix/cli branch July 14, 2023 13:48
@zbeyens zbeyens mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx @udecode/plate-ui@latest add generates bad code
1 participant