Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Us9 #111

Merged
merged 13 commits into from
Dec 4, 2023
Merged

Us9 #111

merged 13 commits into from
Dec 4, 2023

Conversation

dt0602
Copy link
Contributor

@dt0602 dt0602 commented Dec 4, 2023

Automatic login works with create account popup and login popup. Credentials aren't stored when logout button is pressed or the automatic login button isn't checked.

@dt0602 dt0602 requested review from gjquach, himetsai, SRaswan, aditijainn and qzzz11 and removed request for gjquach and himetsai December 4, 2023 06:39
Copy link
Contributor

@aditijainn aditijainn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review using checklist from lecture done in person

Copy link
Contributor

@SRaswan SRaswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ze goat vamos

Copy link
Contributor

@gjquach gjquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done in person

@dt0602 dt0602 merged commit 671fc99 into main Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants