-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added mapping for dw conv #18
base: dev
Are you sure you want to change the base?
Conversation
@@ -1258,8 +1258,10 @@ static void sp_tiled_conv_A_stride( | |||
J, K, J, I); | |||
|
|||
if (new_weights) { | |||
gemmini_extended_compute_preloaded(A_sp_addr, GARBAGE_ADDR, K, I, J, I); | |||
printf("preloaded krow: %d, kcol: %d \n", krow, kcol); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you erase this printf?
} else { | ||
printf("accumulated krow: %d, kcol: %d \n", krow, kcol); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you erase this printf?
@@ -1258,8 +1258,10 @@ static void sp_tiled_conv_A_stride( | |||
J, K, J, I); | |||
|
|||
if (new_weights) { | |||
gemmini_extended_compute_preloaded(A_sp_addr, GARBAGE_ADDR, K, I, J, I); | |||
printf("preloaded krow: %d, kcol: %d \n", krow, kcol); | |||
gemmini_extended_compute_preloaded(A_sp_addr, GARBAGE_ADDR, K, I, J, I); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use spaces for tabbing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just made a few minor requests, but lgtm overall
No description provided.