Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mapping for dw conv #18

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

added mapping for dw conv #18

wants to merge 2 commits into from

Conversation

SeahK
Copy link
Collaborator

@SeahK SeahK commented Apr 8, 2021

No description provided.

@SeahK SeahK requested a review from hngenc April 8, 2021 06:20
@@ -1258,8 +1258,10 @@ static void sp_tiled_conv_A_stride(
J, K, J, I);

if (new_weights) {
gemmini_extended_compute_preloaded(A_sp_addr, GARBAGE_ADDR, K, I, J, I);
printf("preloaded krow: %d, kcol: %d \n", krow, kcol);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you erase this printf?

} else {
printf("accumulated krow: %d, kcol: %d \n", krow, kcol);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you erase this printf?

@@ -1258,8 +1258,10 @@ static void sp_tiled_conv_A_stride(
J, K, J, I);

if (new_weights) {
gemmini_extended_compute_preloaded(A_sp_addr, GARBAGE_ADDR, K, I, J, I);
printf("preloaded krow: %d, kcol: %d \n", krow, kcol);
gemmini_extended_compute_preloaded(A_sp_addr, GARBAGE_ADDR, K, I, J, I);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use spaces for tabbing here?

Copy link
Member

@hngenc hngenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a few minor requests, but lgtm overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants