Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Small Change to Zipper Styled Mimetypes #4174

Merged
merged 2 commits into from
Dec 7, 2024

Conversation

ochi12
Copy link
Contributor

@ochi12 ochi12 commented Dec 1, 2024

I tried to add a little bit more character to zipper styled mimetype icons.
My First Take:

My take would be to make only the icon for 256x256 and 256x256@2x . It looks good on max size but looses detail on smaller sizes between 64x64 >= sizes > 48x48.

The only solution to this is to make the added zipper style simpler until it looks good on 48x48

... So I decided to just add a dept within the zipper.

Original Added Dept

@Feichtmeier
Copy link
Member

@madsrh can you review this since you were the mime type maestro?

@madsrh
Copy link
Member

madsrh commented Dec 7, 2024

Thank you @ochi12
I'm don't think your first take would fit with the Yaru style, so I'm glad that you only added the depth 😊 I think this looks good 👍

@madsrh madsrh merged commit 184701a into ubuntu:master Dec 7, 2024
3 checks passed
@ochi12
Copy link
Contributor Author

ochi12 commented Dec 8, 2024

@madsrh this is odd
image
I think we both missed it. It rendered the wrong icon
image

On my side, I used the render script so it supposed to render the correct icon right?
I will link another PR later to fix my mistake.

ochi12 added a commit to ochi12/yaru that referenced this pull request Dec 8, 2024
Feichtmeier pushed a commit that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants