Remove an issue causing ".login-dialog-prompt-entry" #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a part of the scss file, which causes the login entry field focus borders to not be themed correctly. This part causes ".login-dialog" to be missing in front of ".login-dialog-prompt-entry:focus", which causes the theme to fall back to the default color. If that default color isn't the same as the currently selected Yaru theme color, they mismatch. closes ubuntu#4102
|
The change is a bit weird since this is pure upstream code, so maybe it would be interesting to understand what's conflicting with it. In any case, if you remove the code, please comment it instead so it's clearer why it has been removed (even better if with a a comment) |
Comments the issue causing ".login-dialog-prompt-entry" instead to make it clearer why it was removed.
|
I'm honestly not quite sure how it works, but it doesn't exist in the pure GNOME shell theme and removing it doesn't cause issues for yaru, but instead it fixes that entry border issue. Anyway, I changed it to a comment instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a part of the scss file, which causes the login entry field focus borders to not be themed correctly.
This part causes ".login-dialog" to be missing in front of ".login-dialog-prompt-entry:focus", which causes the theme to fall back to the default color. If that default color isn't the same as the currently selected Yaru theme color, they mismatch.
closes #4102