Skip to content

Commit

Permalink
gnome-shell: Don't give login-dialog another background-color
Browse files Browse the repository at this point in the history
Its parent `lockDialogGroup` has exactly the same background-color
set in the same file. Giving them both the same wasted render time on
overdraw, and caused multi-layer blending artifacts (slight flickering
of the grey background) when the login dialog fades in/out.

While the flicker can also be fixed using `set_offscreen_redirect`,
there's no point adding that overhead when the extra layer doesn't need
to be painted. Removing it halves the average render time of the login
animation.

Closes: #4048
Copied-from: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/d09509b2cbce
  • Loading branch information
vanvugt committed Feb 29, 2024
1 parent c19b3c3 commit a91b304
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ $_gdm_dialog_width: 23em;

/* Login Dialog */
.login-dialog {
background-color: $_gdm_bg;
}

// buttons
Expand Down

0 comments on commit a91b304

Please sign in to comment.