feat(just): add brew-command-not-found setup #1874
Conversation
tulilirockz
force-pushed
the
brew-command-not-found
branch
from
0a41c5e
to
b1e2086
Compare
dosubot
bot
added
size:M
tulilirockz
force-pushed
the
brew-command-not-found
branch
from
b1e2086
to
4a364fa
Compare
|
I think this might be a bit too much. Especially if this is going to install something from brew automatically. While brew is present, it is very much in an opt-in configuration. |
|
This probably should just be a justfile, right? Ill convert it over to that! |
tulilirockz
force-pushed
the
brew-command-not-found
branch
2 times, most recently
from
7e2cf61
to
7b8c124
Compare
tulilirockz
changed the title
|
There you go! It seems to work fine on my machine |
There was a problem hiding this comment.
As it is often quite easy to misunderstand the intention of the review comments let me make it clear here: There are absolutely no rhetorical questions in my comments and all questions are well intended and out of curiosity of understanding your intentions and learning a few things ;)
| BREW_BINARY=/home/linuxbrew/.linuxbrew/bin/brew | ||
| BREW_ROOT=${HOMEBREW_REPOSITORY:-$($BREW_BINARY --repository)} | ||
| if ! $BREW_BINARY -h > /dev/null; then | ||
| echo "Make sure Homebrew is first. Check journalctl -e -u brew-setup.service" |
There was a problem hiding this comment.
Yup, placed it wrong LOL
There was a problem hiding this comment.
In this comment I actually meant that the first sentence in the echo is wrong, isn't it? ;)
There was a problem hiding this comment.
OH! I didnt see that typo till now! Great catch!
| pkexec tee /etc/profile.d/brew-command-not-found.sh > /dev/null <<EOF | ||
| # Check for interactive bash or zsh and that we haven't already been sourced | ||
| if [[ -d /home/linuxbrew/.linuxbrew && \$- == *i* && BREW_COMMAND_NOT_FOUND != 1 ]] ; then | ||
| HB_CNF_HANDLER="${BREW_ROOT}/Library/Taps/homebrew/homebrew-command-not-found/handler.sh" |
There was a problem hiding this comment.
Maybe there is some magic going on here I don't understand but shouldn't you use the same logic as above: BREW_ROOT=${HOMEBREW_REPOSITORY:-$($BREW_BINARY --repository)} . Otherwise, how do you guarantee that this will work? At least on ghcr.io/ublue-os/bluefin:41-20241110 it seems unset.
Maybe this is the reason why fish is not working for you?
It would be awesome if we can get fish to work as that`s my preferred shell ❤️
There was a problem hiding this comment.
If the variable does not have a backslash before it it gets interpreted by the shell, in that code it just expands BREW_ROOT then writes the file, not the other way around
There was a problem hiding this comment.
Ah you are correct, it was quite late yesterday for me ;)
Then I think there could be some issue with hard-coding it here. Suppose the following:
- Somebody customized their homebrew installation and BREW_ROOT is set on their system.
- He/she then calls this just command. The path gets hard-coded to the customizations. Everything works fine.
- Later on the person decides to remove the customizations an remove the brew root under the custom path. This world break brew-command-not-found.
Most of the answers to your questions are: I just wrote bad code! Ill probably rewrite the just recipe with your review :p Thanks for reviewing! |
|
Im on my phone right now so I cant fix the recipe rn, but ill get on my computer, rewrite it and add some comments to clear up the logic |
tulilirockz
force-pushed
the
brew-command-not-found
branch
from
7b8c124
to
a46a709
Compare
|
Just added two comments on the review. Please check them. I can't seem to unresolve the issues or I am too blind to find the button... ;) |
This should setup command-not-found alongside brew-setup. The only thing missing is fish support that I couldnt set up yet (idk why it isnt working). Otherwise this seems good? Just needs a bit more testing. - Fixes #1327