-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): stable-daily tagging #1815
Conversation
@@ -20,6 +20,16 @@ on: | |||
required: false | |||
type: string | |||
default: Tuesday | |||
build_stable_daily: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now, but it feels a bit like a belt and suspenders situation. We are being overly specific it feels like.
@@ -246,15 +256,18 @@ jobs: | |||
COMMIT_TAGS+=("${SHA_SHORT}") | |||
fi | |||
|
|||
TODAY="$(date +%A)" | |||
if [[ ${{ matrix.fedora_version }} == "stable" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much more readable now.
That said I think we have room for improvements in the future.
Builds are skewed, forcing this in. Thanks everyone! |
I have refactored the stable-daily tagging logic to make it much more readable. I hope M2 is happier with this code.
Reference: #1804
Psuedo logic:
In the code, I used the explicit term
stable
instead of${FEDORA_VERSION}
to improve readability. I chose this because we are already in stable logic, so this would always bestable
. If you prefer${FEDORA_VERSION}
I can, of course, put that back in.Manual triggered run will produce: stable, stable-daily
Schedule triggered run on weekly_tag_day: stable, stable-daily
Schedule triggered run on non weekly_tag_days: stable-daily
On top of this I made changes that will allow you to manually build stable or stable-daily only by pushing a button.
Introduces the following workflows.
To make this possible I updated the above pseudo logic like so:
build_stable_weekly
andbuild_stable_daily
are both set totrue
by default inn thereusable-build.yml
and are toggled via the new workflow files.