Make ublksrv_reap_events_uring public #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ming1
reviewed
Jan 24, 2025
include/ublksrv.h
Outdated
| * | ||
| * @param r the ring pointer for io_uring | ||
| */ | ||
| extern int ublksrv_reap_events_uring(struct io_uring *r); |
There was a problem hiding this comment.
Can you name it as ublksrv_queue_reap_events(struct ublksrv_queue *)?
Then we can avoid to add io_uring into interface, meantime ublksrv_reap_events_uring() can be kept as inline.
Thanks,
sahlberg
force-pushed
the
ublksrv_reap_events_uring
branch
from
fc9faa1 to
e1b04e1
Compare
ming1
reviewed
Jan 25, 2025
lib/ublksrv.c
Outdated
| @@ -858,6 +858,11 @@ static int ublksrv_reap_events_uring(struct io_uring *r) | |||
| return count; | |||
| } | |||
|
|
|||
| int ublksrv_queue_reap_events(struct io_uring *r) | |||
There was a problem hiding this comment.
I meant using "struct ublksrv_queue *" as the API's argument, instead of "struct io_uring *" because all queue APIs takes "struct ublksrv_queue *" as its parameter.
Signed-off-by: Ronnie Sahlberg <[email protected]>
sahlberg
force-pushed
the
ublksrv_reap_events_uring
branch
from
e1b04e1 to
0308952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this symbol public. I need it for an app that calls directly to /lib64/libublksrv.so