Adjustments to Python test discovery #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamyDev
approved these changes
Jul 2, 2024
Merged
shuklahy
pushed a commit
that referenced
this pull request
Jul 2, 2024
## What's Changed * Use readFile instead of openTextDocument for regex test case discovery by @mnoah1 in #13 * Add getting started docs by @mnoah1 in #12 * Adjust notifications during sync by @mnoah1 in #14 * Show setup message when no targets returned from sync by @mnoah1 in #15 * Adjustments to Python test discovery by @mnoah1 in #17 * Add results from parameterized tests to parent by @mnoah1 in #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a few tweaks to improve Python test case discovery in files, based on some initial user feedback:
Use selection range for positioning of arrows, so arrow lines up with the function header. The previous range value began at the start of any decorators or other content above the header.
Example of adjusted positions:
Let class names start or end with Test
Add a filter before returning that excludes classes containing no test cases. This will reduce noise in cases where the word Test is in a class name but it is not in fact a test.