-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer generics for assignments #1131
base: master
Are you sure you want to change the base?
Conversation
@haewiful thanks for this! It looks like CI fails on the https://github.com/uber/NullAway/actions/runs/12978381939/job/36192901792?pr=1131#step:5:606 I suggest looking at the code it is crashing on and trying to write a unit test that causes the same failure, which will make it easier to debug. |
# Conflicts: # nullaway/src/main/java/com/uber/nullaway/NullAway.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1131 +/- ##
============================================
- Coverage 88.24% 88.23% -0.01%
- Complexity 2263 2275 +12
============================================
Files 85 85
Lines 7314 7361 +47
Branches 1458 1474 +16
============================================
+ Hits 6454 6495 +41
Misses 432 432
- Partials 428 434 +6 ☔ View full report in Codecov by Sentry. |
Infer Nullability for assignments of instances with type parameters. ex)
Foo<@Nullable Object> f = Foo.make(null);
void genericInferenceOnAssignments()
in GenericMethodTests.java