Skip to content

Commit

Permalink
Update to Checker Framework 3.48.0 (#1030)
Browse files Browse the repository at this point in the history
Fixes #1012.
[Benchmarking](#1030 (comment))
shows any perf difference is within the noise.
  • Loading branch information
msridhar authored Oct 2, 2024
1 parent f3837e8 commit e1298df
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ if (project.hasProperty("epApiVersion")) {

def versions = [
asm : "9.3",
checkerFramework : "3.43.0",
checkerFramework : "3.48.0",
// for comparisons in other parts of the build
errorProneLatest : latestErrorProneVersion,
// The version of Error Prone used to check NullAway's code.
Expand Down
16 changes: 16 additions & 0 deletions nullaway/src/test/java/com/uber/nullaway/CoreTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -1053,4 +1053,20 @@ public void testStaticImportFromSubclass() {
"}")
.doTest();
}

/** testing for no Checker Framework crash */
@Test
public void ternaryBothCasesNull() {
defaultCompilationHelper
.addSourceLines(
"TestCase.java",
"package com.uber;",
"import org.jspecify.annotations.Nullable;",
"public class TestCase {",
" public static @Nullable String foo(String x) {",
" return x.isEmpty() ? null : null;",
" }",
"}")
.doTest();
}
}

0 comments on commit e1298df

Please sign in to comment.